All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fusionio.com>
To: Stefan Behrens <sbehrens@giantdisaster.de>
Cc: <xfs@oss.sgi.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH V4] xfstests: don't remove the two first devices from SCRATCH_DEV_POOL
Date: Fri, 23 Aug 2013 14:32:26 -0400	[thread overview]
Message-ID: <20130823183226.GE29654@localhost.localdomain> (raw)
In-Reply-To: <1377263233-8903-1-git-send-email-sbehrens@giantdisaster.de>

On Fri, Aug 23, 2013 at 03:07:10PM +0200, Stefan Behrens wrote:
> Since common/config is executed twice, if SCRATCH_DEV_POOL is configured
> via the environment, the current code removes the first device entry twice
> which means that you lose the second device for the test.
> 
> The fix is to not remove anything from SCRATCH_DEV_POOL anymore.
> That used to be done (I can only guess) to allow to pass the
> SCRATCH_DEV_POOL as an argument to _scratch_mkfs. Since _scratch_mkfs adds
> the SCRATCH_DEV, the pool mustn't contain that device anymore.
> 
> A new function _scratch_pool_mkfs is introduced that does the expected
> thing.
> 

This didn't break anything and makes sense

Reviewed-by: Josef Bacik <jbacik@fusionio.com>

Thanks,

Josef

WARNING: multiple messages have this Message-ID
From: Josef Bacik <jbacik@fusionio.com>
To: Stefan Behrens <sbehrens@giantdisaster.de>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH V4] xfstests: don't remove the two first devices from SCRATCH_DEV_POOL
Date: Fri, 23 Aug 2013 14:32:26 -0400	[thread overview]
Message-ID: <20130823183226.GE29654@localhost.localdomain> (raw)
In-Reply-To: <1377263233-8903-1-git-send-email-sbehrens@giantdisaster.de>

On Fri, Aug 23, 2013 at 03:07:10PM +0200, Stefan Behrens wrote:
> Since common/config is executed twice, if SCRATCH_DEV_POOL is configured
> via the environment, the current code removes the first device entry twice
> which means that you lose the second device for the test.
> 
> The fix is to not remove anything from SCRATCH_DEV_POOL anymore.
> That used to be done (I can only guess) to allow to pass the
> SCRATCH_DEV_POOL as an argument to _scratch_mkfs. Since _scratch_mkfs adds
> the SCRATCH_DEV, the pool mustn't contain that device anymore.
> 
> A new function _scratch_pool_mkfs is introduced that does the expected
> thing.
> 

This didn't break anything and makes sense

Reviewed-by: Josef Bacik <jbacik@fusionio.com>

Thanks,

Josef

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-08-23 18:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-23 13:07 Stefan Behrens
2013-08-23 13:07 ` Stefan Behrens
2013-08-23 13:07 ` [PATCH][RESEND] xfstests: add a test for btrfs device replace operation Stefan Behrens
2013-08-23 13:07   ` Stefan Behrens
2013-08-23 18:35   ` Josef Bacik
2013-08-23 18:35     ` Josef Bacik
2013-08-28 16:25   ` Rich Johnston
2013-08-28 16:25     ` Rich Johnston
2013-08-23 13:07 ` [PATCH] xfstests: update _filter_size() for Btrfs Stefan Behrens
2013-08-23 13:07   ` Stefan Behrens
2013-08-23 18:34   ` Josef Bacik
2013-08-23 18:34     ` Josef Bacik
2013-08-28 15:38   ` Rich Johnston
2013-08-28 15:38     ` Rich Johnston
2013-08-23 13:07 ` [PATCH] xfstest: fix btrfs/006 for 10+ devices in SCRATCH_DEV_POOL Stefan Behrens
2013-08-23 13:07   ` Stefan Behrens
2013-08-23 18:33   ` Josef Bacik
2013-08-23 18:33     ` Josef Bacik
2013-08-28 15:30   ` Rich Johnston
2013-08-28 15:30     ` Rich Johnston
2013-08-23 18:32 ` Josef Bacik [this message]
2013-08-23 18:32   ` [PATCH V4] xfstests: don't remove the two first devices from SCRATCH_DEV_POOL Josef Bacik
2013-08-28 15:18 ` Rich Johnston
2013-08-28 15:18   ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130823183226.GE29654@localhost.localdomain \
    --to=jbacik@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=sbehrens@giantdisaster.de \
    --cc=xfs@oss.sgi.com \
    --subject='Re: [PATCH V4] xfstests: don'\''t remove the two first devices from SCRATCH_DEV_POOL' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.