From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dan.carpenter@oracle.com>
MIME-Version: 1.0
Message-ID: <20130823202349.GW22811@mwanda>
Date: Fri, 23 Aug 2013 13:23:49 -0700 (PDT)
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 08/12] staging: dgap: tty.c: fixes ioctl param list
References: <1377136122-13338-1-git-send-email-lidza.louina@gmail.com>
 <1377136122-13338-8-git-send-email-lidza.louina@gmail.com>
In-Reply-To: <1377136122-13338-8-git-send-email-lidza.louina@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
List-ID: <driverdev-devel.linuxdriverproject.org>
To: Lidza Louina <lidza.louina@gmail.com>
Cc: driverdev-devel@linuxdriverproject.org, Greg KH <gregkh@linuxfoundation.org>, Mark Hounschell <markh@compro.net>

On Wed, Aug 21, 2013 at 09:48:38PM -0400, Lidza Louina wrote:
> -static int dgap_tty_ioctl(struct tty_struct *tty, struct file *file, unsigned int cmd,
> +static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
>  		unsigned long arg)

Btw, now that this file compiles I see it in my static checker runs.

dgap_tty_ioctl() takes a lock but always returns before unlocking.

>  {
>  	struct board_t *bd;
> @@ -3423,41 +3423,6 @@ static int dgap_tty_ioctl(struct tty_struct *tty, struct file *file, unsigned in
>  
>  		return(-ENOIOCTLCMD);

In other words, these return statements should be breaks so we hit
the call to:

	DGNC_UNLOCK(ch->ch_lock, lock_flags);

regards,
dan carpenter