From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 51B3D2C0097 for ; Sat, 24 Aug 2013 07:47:25 +1000 (EST) Date: Fri, 23 Aug 2013 23:47:19 +0200 From: Anatolij Gustschin To: Gerhard Sittig Subject: Re: [PATCH v4 04/31] mtd: mpc5121_nfc: cleanup clock API use Message-ID: <20130823234719.5b14126c@crub> In-Reply-To: <1375821851-31609-5-git-send-email-gsi@denx.de> References: <1374495298-22019-1-git-send-email-gsi@denx.de> <1375821851-31609-1-git-send-email-gsi@denx.de> <1375821851-31609-5-git-send-email-gsi@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: David Woodhouse , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 6 Aug 2013 22:43:44 +0200 Gerhard Sittig wrote: > use devm_clk_get() for automatic put after device close, check for and > propagate errors when enabling clocks, need to prepare clocks before > they can get enabled, adjust error code paths to correctly balance > get/put and prepare/unprepare and enable/disable calls > > Signed-off-by: Gerhard Sittig > --- > drivers/mtd/nand/mpc5121_nfc.c | 21 ++++++++++++--------- > 1 file changed, 12 insertions(+), 9 deletions(-) Applied to mpc5xxx tree, thanks! Anatolij