From: Huang Shijie <shijie8@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: dedekind1@gmail.com, akinobu.mita@gmail.com,
matthieu.castet@parrot.com, Huang Shijie <b32955@freescale.com>,
linux-mtd@lists.infradead.org, dwmw2@infradead.org
Subject: Re: [PATCH v2 4/9] mtd: gpmi: rewrite the gpmi_ecc_write_oob() to support the jffs2
Date: Sat, 24 Aug 2013 15:18:13 -0400 [thread overview]
Message-ID: <20130824191757.GA23955@gmail.com> (raw)
In-Reply-To: <20130824061916.GC32074@brian-ubuntu>
On Fri, Aug 23, 2013 at 11:19:16PM -0700, Brian Norris wrote:
> On Mon, Aug 19, 2013 at 10:31:13AM +0800, Huang Shijie wrote:
> > - */
> > - return -EPERM;
> > + struct nand_oobfree *of = gpmi_hw_ecclayout.oobfree;
>
> Why do you directly access your static layout? I think you should use
> the proper indirection, through chip->ecc.layout. (There's a similar
yes, it is better to use the chip->ecc.layout.
> issue with set_geometry_by_ecc_info() currently.)
Not a same issue. The set_geometry_by_ecc_info() is called before we
call the nand_scan_tail(). so it should not changed.
>
> [BTW, I was about to recommend nand_chip.ecclayout, but it looks like
> that is just a dead field. It's not initialized anywhere, AFAICT, and if
The jffs2 write may also uses the ecclayout.
thanks
Huang Shijie
next prev parent reply other threads:[~2013-08-24 7:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 2:31 [PATCH v2 0/9] About the SLC/MLC Huang Shijie
2013-08-19 2:31 ` [PATCH v2 1/9] mtd: nand: rename the cellinfo to bits_per_cell Huang Shijie
2013-08-24 5:49 ` Brian Norris
2013-08-25 3:52 ` Huang Shijie
2013-08-19 2:31 ` [PATCH v2 2/9] mtd: set the cell information for ONFI nand Huang Shijie
2013-08-19 2:31 ` [PATCH v2 3/9] mtd: print out the cell information for nand chip Huang Shijie
2013-08-24 5:58 ` Brian Norris
2013-08-24 21:02 ` Ezequiel Garcia
2013-08-25 16:04 ` Huang Shijie
2013-08-19 2:31 ` [PATCH v2 4/9] mtd: gpmi: rewrite the gpmi_ecc_write_oob() to support the jffs2 Huang Shijie
2013-08-24 6:19 ` Brian Norris
2013-08-24 19:18 ` Huang Shijie [this message]
2013-08-24 7:17 ` Brian Norris
2013-08-19 2:31 ` [PATCH v2 5/9] mtd: add more comment for MTD_NANDFLASH/MTD_MLCNANDFLASH Huang Shijie
2013-08-19 2:31 ` [PATCH v2 6/9] mtd: fix the wrong mtd->type for nand chip Huang Shijie
2013-08-19 2:31 ` [PATCH v2 7/9] jffs2: init the ret with -EINVAL Huang Shijie
2013-08-24 6:37 ` Brian Norris
2013-08-25 4:00 ` Huang Shijie
2013-08-19 2:31 ` [PATCH v2 8/9] mtd: add MTD_MLCNANDFLASH case for mtd_type_show() Huang Shijie
2013-08-19 2:31 ` [PATCH v2 9/9] mtd: add a helper to detect the nand type Huang Shijie
2013-08-19 8:59 ` [PATCH v2 append] mtd: mtd-abi: " Huang Shijie
2013-08-20 5:32 ` [PATCH append fix] " Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130824191757.GA23955@gmail.com \
--to=shijie8@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=matthieu.castet@parrot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.