From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753520Ab3H1KUA (ORCPT ); Wed, 28 Aug 2013 06:20:00 -0400 Received: from top.free-electrons.com ([176.31.233.9]:41351 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752513Ab3H1KT7 convert rfc822-to-8bit (ORCPT ); Wed, 28 Aug 2013 06:19:59 -0400 Date: Wed, 28 Aug 2013 12:19:43 +0200 From: Thomas Petazzoni To: Sebastian Hesselbarth Cc: Jean-Francois Moine , Mark Rutland , devicetree@vger.kernel.org, Russell King , Jason Cooper , Pawel Moll , Stephen Warren , linux-kernel@vger.kernel.org, Rob Herring , Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, Ian Campbell Subject: Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT Message-ID: <20130828121943.1c8327ca@skate> In-Reply-To: <521DCD33.2070008@gmail.com> References: <20130828113459.48ecbb34@armhf> <521DCD33.2070008@gmail.com> Organization: Free Electrons X-Mailer: Claws Mail 3.9.1 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sebastian, Jean-François, On Wed, 28 Aug 2013 12:13:07 +0200, Sebastian Hesselbarth wrote: > On 08/28/2013 11:34 AM, Jean-Francois Moine wrote: > > This patch adds the nodes to instantiate the audio devices of the Dove > > boards. > > > > Signed-off-by: Jean-Francois Moine > > --- > > arch/arm/boot/dts/dove.dtsi | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi > > index 499abad..78227e2 100644 > > --- a/arch/arm/boot/dts/dove.dtsi > > +++ b/arch/arm/boot/dts/dove.dtsi > > @@ -573,6 +573,24 @@ > > phy-handle = <ðphy>; > > }; > > }; > > + > > + i2s0: audio-controller@b0000 { > > + compatible = "marvell,mvebu-audio"; > > [added Gregory to Cc] > > Jean-Francois, > > as Mark Brown already took the bindings patch for above generic > compatible, how are we going to discriminate different > implementations/features of Dove, Kirkwood, and Armada 370? I agree that mvebu-audio is not a really good compatible string. It should use the first SoC that introduced the IP block, so that if future SOCs have variations, we can introduce separate compatible strings. So for now, the compatible string should be kirkwood-audio. Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT Date: Wed, 28 Aug 2013 12:19:43 +0200 Message-ID: <20130828121943.1c8327ca@skate> References: <20130828113459.48ecbb34@armhf> <521DCD33.2070008@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <521DCD33.2070008@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sebastian Hesselbarth Cc: Mark Rutland , Jean-Francois Moine , Russell King , Jason Cooper , Pawel Moll , devicetree@vger.kernel.org, Stephen Warren , linux-kernel@vger.kernel.org, Rob Herring , Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, Ian Campbell List-Id: devicetree@vger.kernel.org U2ViYXN0aWFuLCBKZWFuLUZyYW7Dp29pcywKCk9uIFdlZCwgMjggQXVnIDIwMTMgMTI6MTM6MDcg KzAyMDAsIFNlYmFzdGlhbiBIZXNzZWxiYXJ0aCB3cm90ZToKPiBPbiAwOC8yOC8yMDEzIDExOjM0 IEFNLCBKZWFuLUZyYW5jb2lzIE1vaW5lIHdyb3RlOgo+ID4gVGhpcyBwYXRjaCBhZGRzIHRoZSBu b2RlcyB0byBpbnN0YW50aWF0ZSB0aGUgYXVkaW8gZGV2aWNlcyBvZiB0aGUgRG92ZQo+ID4gYm9h cmRzLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IEplYW4tRnJhbmNvaXMgTW9pbmUgPG1vaW5lamZA ZnJlZS5mcj4KPiA+IC0tLQo+ID4gICBhcmNoL2FybS9ib290L2R0cy9kb3ZlLmR0c2kgICAgICAg ICAgICAgICAgICB8IDE4ICsrKysrKysrKysrKysrKysrKwo+ID4gICAxIGZpbGUgY2hhbmdlZCwg MTggaW5zZXJ0aW9ucygrKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9k b3ZlLmR0c2kgYi9hcmNoL2FybS9ib290L2R0cy9kb3ZlLmR0c2kKPiA+IGluZGV4IDQ5OWFiYWQu Ljc4MjI3ZTIgMTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9kb3ZlLmR0c2kKPiA+ ICsrKyBiL2FyY2gvYXJtL2Jvb3QvZHRzL2RvdmUuZHRzaQo+ID4gQEAgLTU3Myw2ICs1NzMsMjQg QEAKPiA+ICAgCQkJCQlwaHktaGFuZGxlID0gPCZldGhwaHk+Owo+ID4gICAJCQkJfTsKPiA+ICAg CQkJfTsKPiA+ICsKPiA+ICsJCQlpMnMwOiBhdWRpby1jb250cm9sbGVyQGIwMDAwIHsKPiA+ICsJ CQkJY29tcGF0aWJsZSA9ICJtYXJ2ZWxsLG12ZWJ1LWF1ZGlvIjsKPiAKPiBbYWRkZWQgR3JlZ29y eSB0byBDY10KPiAKPiBKZWFuLUZyYW5jb2lzLAo+IAo+IGFzIE1hcmsgQnJvd24gYWxyZWFkeSB0 b29rIHRoZSBiaW5kaW5ncyBwYXRjaCBmb3IgYWJvdmUgZ2VuZXJpYwo+IGNvbXBhdGlibGUsIGhv dyBhcmUgd2UgZ29pbmcgdG8gZGlzY3JpbWluYXRlIGRpZmZlcmVudAo+IGltcGxlbWVudGF0aW9u cy9mZWF0dXJlcyBvZiBEb3ZlLCBLaXJrd29vZCwgYW5kIEFybWFkYSAzNzA/CgpJIGFncmVlIHRo YXQgbXZlYnUtYXVkaW8gaXMgbm90IGEgcmVhbGx5IGdvb2QgY29tcGF0aWJsZSBzdHJpbmcuIEl0 CnNob3VsZCB1c2UgdGhlIGZpcnN0IFNvQyB0aGF0IGludHJvZHVjZWQgdGhlIElQIGJsb2NrLCBz byB0aGF0IGlmCmZ1dHVyZSBTT0NzIGhhdmUgdmFyaWF0aW9ucywgd2UgY2FuIGludHJvZHVjZSBz ZXBhcmF0ZSBjb21wYXRpYmxlCnN0cmluZ3MuCgpTbyBmb3Igbm93LCB0aGUgY29tcGF0aWJsZSBz dHJpbmcgc2hvdWxkIGJlIGtpcmt3b29kLWF1ZGlvLgoKVGhhbmtzLAoKVGhvbWFzCi0tIApUaG9t YXMgUGV0YXp6b25pLCBGcmVlIEVsZWN0cm9ucwpLZXJuZWwsIGRyaXZlcnMsIHJlYWwtdGltZSBh bmQgZW1iZWRkZWQgTGludXgKZGV2ZWxvcG1lbnQsIGNvbnN1bHRpbmcsIHRyYWluaW5nIGFuZCBz dXBwb3J0LgpodHRwOi8vZnJlZS1lbGVjdHJvbnMuY29tCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) Date: Wed, 28 Aug 2013 12:19:43 +0200 Subject: [PATCH 1/2] ARM: Dove: Add the audio devices in DT In-Reply-To: <521DCD33.2070008@gmail.com> References: <20130828113459.48ecbb34@armhf> <521DCD33.2070008@gmail.com> Message-ID: <20130828121943.1c8327ca@skate> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Sebastian, Jean-Fran?ois, On Wed, 28 Aug 2013 12:13:07 +0200, Sebastian Hesselbarth wrote: > On 08/28/2013 11:34 AM, Jean-Francois Moine wrote: > > This patch adds the nodes to instantiate the audio devices of the Dove > > boards. > > > > Signed-off-by: Jean-Francois Moine > > --- > > arch/arm/boot/dts/dove.dtsi | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi > > index 499abad..78227e2 100644 > > --- a/arch/arm/boot/dts/dove.dtsi > > +++ b/arch/arm/boot/dts/dove.dtsi > > @@ -573,6 +573,24 @@ > > phy-handle = <ðphy>; > > }; > > }; > > + > > + i2s0: audio-controller at b0000 { > > + compatible = "marvell,mvebu-audio"; > > [added Gregory to Cc] > > Jean-Francois, > > as Mark Brown already took the bindings patch for above generic > compatible, how are we going to discriminate different > implementations/features of Dove, Kirkwood, and Armada 370? I agree that mvebu-audio is not a really good compatible string. It should use the first SoC that introduced the IP block, so that if future SOCs have variations, we can introduce separate compatible strings. So for now, the compatible string should be kirkwood-audio. Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com