From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756080Ab3H2JiB (ORCPT ); Thu, 29 Aug 2013 05:38:01 -0400 Received: from smtp5-g21.free.fr ([212.27.42.5]:41966 "EHLO smtp5-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755878Ab3H2JiA convert rfc822-to-8bit (ORCPT ); Thu, 29 Aug 2013 05:38:00 -0400 Date: Thu, 29 Aug 2013 11:38:48 +0200 From: Jean-Francois Moine To: Sergei Shtylyov Cc: linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth , Jason Cooper , Mark Rutland , devicetree@vger.kernel.org, Russell King , Ian Campbell , Pawel Moll , Stephen Warren , linux-kernel@vger.kernel.org, Rob Herring Subject: Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT Message-ID: <20130829113848.6d8f7f21@armhf> In-Reply-To: <521E5438.90109@cogentembedded.com> References: <20130828113459.48ecbb34@armhf> <521E5438.90109@cogentembedded.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.20; arm-unknown-linux-gnueabihf) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Aug 2013 23:49:12 +0400 Sergei Shtylyov wrote: > > diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi > > index 499abad..78227e2 100644 > > --- a/arch/arm/boot/dts/dove.dtsi > > +++ b/arch/arm/boot/dts/dove.dtsi > > @@ -573,6 +573,24 @@ > > phy-handle = <ðphy>; > > }; > > }; > > + > > + i2s0: audio-controller@b0000 { > > According to ePAPR [1] the node should be called "sound", not > "audio-controller". > > > + compatible = "marvell,mvebu-audio"; > > + reg = <0xb0000 0x2210>; > > + interrupts = <19>, <20>; > > + clocks = <&gate_clk 12>; > > + clock-names = "internal"; > > + status = "disabled"; > > + }; AFAIK, "sound" describes the global audio subsystem. For the Cubox, this will be done by something like: sound { compatible = "simple-audio"; audio-controller = <&i2s1>; audio-codec = <&spdif>; codec-dai-name = "dit-hifi"; }; -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Thu, 29 Aug 2013 11:38:48 +0200 Subject: [PATCH 1/2] ARM: Dove: Add the audio devices in DT In-Reply-To: <521E5438.90109@cogentembedded.com> References: <20130828113459.48ecbb34@armhf> <521E5438.90109@cogentembedded.com> Message-ID: <20130829113848.6d8f7f21@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 28 Aug 2013 23:49:12 +0400 Sergei Shtylyov wrote: > > diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi > > index 499abad..78227e2 100644 > > --- a/arch/arm/boot/dts/dove.dtsi > > +++ b/arch/arm/boot/dts/dove.dtsi > > @@ -573,6 +573,24 @@ > > phy-handle = <ðphy>; > > }; > > }; > > + > > + i2s0: audio-controller at b0000 { > > According to ePAPR [1] the node should be called "sound", not > "audio-controller". > > > + compatible = "marvell,mvebu-audio"; > > + reg = <0xb0000 0x2210>; > > + interrupts = <19>, <20>; > > + clocks = <&gate_clk 12>; > > + clock-names = "internal"; > > + status = "disabled"; > > + }; AFAIK, "sound" describes the global audio subsystem. For the Cubox, this will be done by something like: sound { compatible = "simple-audio"; audio-controller = <&i2s1>; audio-codec = <&spdif>; codec-dai-name = "dit-hifi"; }; -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/