All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH V7 0/5] Continuous Leaky Bucket Throttling
Date: Thu, 29 Aug 2013 20:01:58 +0200	[thread overview]
Message-ID: <20130829180158.GB5241@irqsave.net> (raw)
In-Reply-To: <20130829090945.GA31923@stefanha-thinkpad.redhat.com>

> Here is my understanding of how the algorithm works:
> 
> There is a "max" burst value which is a guaranteed allowance.  If max is
> 100 units then you can always use up to 100 units without being
> throttled.
> 
> After the max burst value has been exceeded, requests are throttled down
> to the "avg" rate value.  The way it works is like this:
> 
> 1. If the max hasn't been reached, allow the request through.
> 2. If the max has been reached, schedule a timer for when the bucket
>    level comes back down to max.
> 3. Increment bucket level when the request is allowed through.
> 4. Drain bucket level according to avg rate as time passes.

Another point is that the initial ability to burst replenish when the guest does
not do any I/Os.

One usage of this is compute intensive tasks where slice of time are dedicated
to computations and separated by a flush to disk of the resulting data.

Best regards

Benoît

      parent reply	other threads:[~2013-08-29 18:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28 15:07 [Qemu-devel] [PATCH V7 0/5] Continuous Leaky Bucket Throttling Benoît Canet
2013-08-28 15:07 ` [Qemu-devel] [PATCH V7 1/5] throttle: Add a new throttling API implementing continuous leaky bucket Benoît Canet
2013-08-28 15:07 ` [Qemu-devel] [PATCH V7 2/5] throttle: Add units tests Benoît Canet
2013-08-28 15:07 ` [Qemu-devel] [PATCH V7 3/5] block: Enable the new throttling code in the block layer Benoît Canet
2013-08-28 15:07 ` [Qemu-devel] [PATCH V7 4/5] block: Add support for throttling burst max in QMP and the command line Benoît Canet
2013-08-30 14:28   ` Eric Blake
2013-08-28 15:07 ` [Qemu-devel] [PATCH V7 5/5] block: Add iops_size to do the iops accounting for a given io size Benoît Canet
2013-08-30 14:39   ` Eric Blake
2013-08-29  9:09 ` [Qemu-devel] [PATCH V7 0/5] Continuous Leaky Bucket Throttling Stefan Hajnoczi
2013-08-29  9:37   ` Benoît Canet
2013-08-30  9:53     ` Stefan Hajnoczi
2013-08-30 10:06       ` Paolo Bonzini
2013-08-30 14:21         ` Stefan Hajnoczi
2013-08-29 18:01   ` Benoît Canet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130829180158.GB5241@irqsave.net \
    --to=benoit.canet@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.