From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756918Ab3H2SfC (ORCPT ); Thu, 29 Aug 2013 14:35:02 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:51129 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756902Ab3H2SfA (ORCPT ); Thu, 29 Aug 2013 14:35:00 -0400 Date: Thu, 29 Aug 2013 19:34:32 +0100 From: Russell King - ARM Linux To: Mark Brown Cc: Sebastian Hesselbarth , Thomas Petazzoni , Mark Rutland , Jean-Francois Moine , Jason Cooper , Pawel Moll , devicetree@vger.kernel.org, Stephen Warren , linux-kernel@vger.kernel.org, Rob Herring , Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, Ian Campbell , liam.r.girdwood@intel.com Subject: Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT Message-ID: <20130829183432.GT6617@n2100.arm.linux.org.uk> References: <20130828113459.48ecbb34@armhf> <521DCD33.2070008@gmail.com> <20130828121943.1c8327ca@skate> <521DD057.4040208@gmail.com> <20130829161217.GK10783@sirena.org.uk> <20130829163358.GS6617@n2100.arm.linux.org.uk> <20130829171210.GM10783@sirena.org.uk> <521F8CB3.5060407@gmail.com> <20130829182010.GQ10783@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130829182010.GQ10783@sirena.org.uk> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 29, 2013 at 07:20:11PM +0100, Mark Brown wrote: > On Thu, Aug 29, 2013 at 08:02:27PM +0200, Sebastian Hesselbarth wrote: > > > > it is referring the same differences Russell already mentioned. But I > > already came to the conclusion, that we don't need the information in > > the binding. For example, if you use that controller on Dove and you > > hook it up for SPDIF-in (which it hasn't), than I consider this a > > DT bug. No need to double-check that in the driver. From that p-o-v, > > please just let the current binding as is. > > OK, great - none of these devices have any differences which are visible > only within the controller, they're all extra external interfaces? Dove Audio 0: - I2S in - I2S out - No SPDIF Dove Audio 1: - I2S in - I2S out - SPDIF out only Both these variants occur on the same SoC. Kirkwood: - I2S in - SPDIF in - I2S out - SPDIF out Preconditions: 1. Only one input can be used at any one time. 2. One output can be used or both if enabled simultaneously. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Thu, 29 Aug 2013 19:34:32 +0100 Subject: [PATCH 1/2] ARM: Dove: Add the audio devices in DT In-Reply-To: <20130829182010.GQ10783@sirena.org.uk> References: <20130828113459.48ecbb34@armhf> <521DCD33.2070008@gmail.com> <20130828121943.1c8327ca@skate> <521DD057.4040208@gmail.com> <20130829161217.GK10783@sirena.org.uk> <20130829163358.GS6617@n2100.arm.linux.org.uk> <20130829171210.GM10783@sirena.org.uk> <521F8CB3.5060407@gmail.com> <20130829182010.GQ10783@sirena.org.uk> Message-ID: <20130829183432.GT6617@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Aug 29, 2013 at 07:20:11PM +0100, Mark Brown wrote: > On Thu, Aug 29, 2013 at 08:02:27PM +0200, Sebastian Hesselbarth wrote: > > > > it is referring the same differences Russell already mentioned. But I > > already came to the conclusion, that we don't need the information in > > the binding. For example, if you use that controller on Dove and you > > hook it up for SPDIF-in (which it hasn't), than I consider this a > > DT bug. No need to double-check that in the driver. From that p-o-v, > > please just let the current binding as is. > > OK, great - none of these devices have any differences which are visible > only within the controller, they're all extra external interfaces? Dove Audio 0: - I2S in - I2S out - No SPDIF Dove Audio 1: - I2S in - I2S out - SPDIF out only Both these variants occur on the same SoC. Kirkwood: - I2S in - SPDIF in - I2S out - SPDIF out Preconditions: 1. Only one input can be used at any one time. 2. One output can be used or both if enabled simultaneously.