From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH RFC 10/13] ASoC: kirkwood-t5325: add DAPM links between codec and cpu DAI Date: Fri, 30 Aug 2013 17:10:05 +0100 Message-ID: <20130830161005.GZ6617@n2100.arm.linux.org.uk> References: <20130820185019.GP30073@sirena.org.uk> <20130820201824.GA17845@n2100.arm.linux.org.uk> <1377199370.2618.99.camel@loki> <20130822201658.GK6617@n2100.arm.linux.org.uk> <1377259994.2444.41.camel@loki> <20130823125803.GN6617@n2100.arm.linux.org.uk> <20130823165800.GB30617@sirena.org.uk> <20130823174505.GQ6617@n2100.arm.linux.org.uk> <20130830112705.GU6617@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from caramon.arm.linux.org.uk (caramon.arm.linux.org.uk [78.32.30.218]) by alsa0.perex.cz (Postfix) with ESMTP id D29E72618EE for ; Fri, 30 Aug 2013 18:10:23 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20130830112705.GU6617@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Liam Girdwood Cc: Liam Girdwood , Takashi Iwai , alsa-devel , Mark Brown , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org On Fri, Aug 30, 2013 at 12:27:05PM +0100, Russell King - ARM Linux wrote: > 1. The combining of the CPU and platform code(s) under one device is > absolutely no problem for ASoC, there's multiple drivers which do this > already. While this is a true statement, it creates the bug at the > heart of this thread - and the bug _occuring_ has nothing to do with > DPCM. The bug is caused solely by the combining of the two components. Right, having gone back and looked at this in-depth again, and tried some experiments, I no longer need this problem fixed for the non-DPCM code to work, but I do still need to do this: > 4. By adding the AIFs and routes, I'm bypassing/abusing the ASoC DAI core. > If this were to be the case, why does your DPCM driver set them up. > Therefore, my conclusion is that Mark was wrong about this too. Yes, > it may be that for the time being it's not that appealing, because as > DPCM doesn't work in mainline, I'm unable to separate the DAI link > between the CPU and the Codec. That doesn't make the creation of > the routes any more wrong when they're the exact same routes which > need to be created for DPCM - especially when they're relied upon for > there to be any audio output what so ever from the driver. so I can detect which output paths to enable. I will be posting updated patches shortly, which will just be those which Mark hasn't taken yet. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Fri, 30 Aug 2013 17:10:05 +0100 Subject: [alsa-devel] [PATCH RFC 10/13] ASoC: kirkwood-t5325: add DAPM links between codec and cpu DAI In-Reply-To: <20130830112705.GU6617@n2100.arm.linux.org.uk> References: <20130820185019.GP30073@sirena.org.uk> <20130820201824.GA17845@n2100.arm.linux.org.uk> <1377199370.2618.99.camel@loki> <20130822201658.GK6617@n2100.arm.linux.org.uk> <1377259994.2444.41.camel@loki> <20130823125803.GN6617@n2100.arm.linux.org.uk> <20130823165800.GB30617@sirena.org.uk> <20130823174505.GQ6617@n2100.arm.linux.org.uk> <20130830112705.GU6617@n2100.arm.linux.org.uk> Message-ID: <20130830161005.GZ6617@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Aug 30, 2013 at 12:27:05PM +0100, Russell King - ARM Linux wrote: > 1. The combining of the CPU and platform code(s) under one device is > absolutely no problem for ASoC, there's multiple drivers which do this > already. While this is a true statement, it creates the bug at the > heart of this thread - and the bug _occuring_ has nothing to do with > DPCM. The bug is caused solely by the combining of the two components. Right, having gone back and looked at this in-depth again, and tried some experiments, I no longer need this problem fixed for the non-DPCM code to work, but I do still need to do this: > 4. By adding the AIFs and routes, I'm bypassing/abusing the ASoC DAI core. > If this were to be the case, why does your DPCM driver set them up. > Therefore, my conclusion is that Mark was wrong about this too. Yes, > it may be that for the time being it's not that appealing, because as > DPCM doesn't work in mainline, I'm unable to separate the DAI link > between the CPU and the Codec. That doesn't make the creation of > the routes any more wrong when they're the exact same routes which > need to be created for DPCM - especially when they're relied upon for > there to be any audio output what so ever from the driver. so I can detect which output paths to enable. I will be posting updated patches shortly, which will just be those which Mark hasn't taken yet.