From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Mon, 09 Sep 2013 17:41:46 +0200 Subject: [U-Boot] [PATCH] config: consolidate CONFIG_SYS_HZ definition In-Reply-To: <522DE2FF.2080001@gmail.com> References: <1378670088-17602-1-git-send-email-robherring2@gmail.com> <20130909140629.4614D380DE2@gemini.denx.de> <522DE2FF.2080001@gmail.com> Message-ID: <20130909154146.532CB380E12@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Rob, In message <522DE2FF.2080001@gmail.com> you wrote: > > What do I do with current boards that are wrong? I should make all these Good question... > boards have build errors or fix them to use 1000 which may break them at > runtime depending on their possible misuse of CONFIG_SYS_HZ? > > include/configs/KAREF.h:#define CONFIG_SYS_HZ 100 > /* decr freq: 1 ms ticks */ > include/configs/M5271EVB.h:#define CONFIG_SYS_HZ > 1000000 > include/configs/METROBOX.h:#define CONFIG_SYS_HZ > 100 /* decr freq: 1 ms ticks */ > include/configs/MVBLUE.h:#define CONFIG_SYS_HZ 10000 > include/configs/idmr.h:#define CONFIG_SYS_HZ > (50000000 / 64) > include/configs/mini2440.h:#define CONFIG_SYS_HZ > 1562500 > include/configs/mx1ads.h:#define CONFIG_SYS_HZ 3686400 > include/configs/omap3_zoom2.h:#define CONFIG_SYS_HZ > ((V_SCLK) / (2 << CONFIG_SYS_PTV)) > include/configs/omap730p2.h:#define CONFIG_SYS_HZ > ((CONFIG_SYS_CLK_FREQ)/(2 << CONFIG_SYS_PTV)) > include/configs/rsk7203.h:#define CONFIG_SYS_HZ > (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) > include/configs/rsk7264.h:#define CONFIG_SYS_HZ > (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) > include/configs/rsk7269.h:#define CONFIG_SYS_HZ > (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) > include/configs/scb9328.h:#define CONFIG_SYS_HZ 3686400 > /* incrementer freq: 3.6864 MHz */ > include/configs/versatile.h:#define CONFIG_SYS_HZ > (1000000 / 256) Hm... which of these boards are actually still being maintained? KAREF and METROBOX are PPC systems, and the comment suggests that the value is actually just a typo. Here it should be harmless to change this to use 1000 Hz instead. Ditto probably for MVBLUE. The rest might actually be dead? Guess we should have their builds break and make the board maintainers fix them. If they don't (because the boards are unmaintained), we will drop the board code from the repo. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de There's nothing disgusting about it [the Companion]. It's just another life form, that's all. You get used to those things. -- McCoy, "Metamorphosis", stardate 3219.8