[U-Boot] [PATCH] net: fec: Avoid MX28 bus sync issue

From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: fec: Avoid MX28 bus sync issue
Date: Thu, 12 Sep 2013 20:17:57 +0200	[thread overview]
Message-ID: <20130912181757.5F102380189@gemini.denx.de> (raw)
In-Reply-To: <201309121605.04824.marex@denx.de>

Dear Marek Vasut,

In message <201309121605.04824.marex@denx.de> you wrote:
> 
> Looking at the code one more time, it'd make most sense to simply allocate the 
> buffer NOT on stack, but with some memalign-kind-of call to avoid this abuse of 
> stack. You see, the max packet size is around 2k, which is quite a lot. How does 
> this proposal sound to you ?

It makes perfect sense to allocate variable with function scope only
on the stack.  That's what the stack has been invented for.

If there is a bug with that, this mug must be isolated and fixed.  It
makes zero sense to just paper over it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Two wrongs don't make a right, but three rights make a left.