From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Fri, 13 Sep 2013 19:46:52 +0200
Subject: [U-Boot] [PATCH] net: fec: Avoid MX28 bus sync issue
In-Reply-To: <201309131824.52506.marex@denx.de>
References: <1373583784-7129-1-git-send-email-marex@denx.de>
	<5232F2E7.4050407@digi.com>
	<20130913160644.CA908380621@gemini.denx.de>
	<201309131824.52506.marex@denx.de>
Message-ID: <20130913174652.1F9E8380189@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Marek Vasut,

In message <201309131824.52506.marex@denx.de> you wrote:
> 
> > > -       uchar buff[FEC_MAX_PKT_SIZE] __aligned(ARCH_DMA_MINALIGN);
> > > +       /* Align the receive buffer */
> > > +       uchar buff_unaligned[FEC_MAX_PKT_SIZE + (ARCH_DMA_MINALIGN - 1)];
> > > +       uchar *buff = ((uint32_t)buff_unaligned + (ARCH_DMA_MINALIGN -
> > > 1)) & ~(ARCH_DMA_MINALIGN - 1);
> > 
> > You should use the ALIGN() macro here.
> 
> We already have this stuff in include/common.h ... ALLOC_CACHE_ALIGNED_BUFFER it 
> is called IIRC

That's ALLOC_CACHE_ALIGN_BUFFER.   Thanks.

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Anyone who isn't confused here doesn't really know what's going on.