All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] trace: show more and exactly help information about snapshot
@ 2013-09-14  4:59 Wang YanQing
  2013-09-14 11:31 ` Steven Rostedt
  0 siblings, 1 reply; 2+ messages in thread
From: Wang YanQing @ 2013-09-14  4:59 UTC (permalink / raw)
  To: rostedt; +Cc: fweisbec, mingo, linux-kernel

Actually, they both are correct:

	default:
		if (tr->allocated_snapshot) {
			if (iter->cpu_file == RING_BUFFER_ALL_CPUS)
				tracing_reset_online_cpus(&tr->max_buffer);
			else
				tracing_reset(&tr->max_buffer,	iter->cpu_file);
		}
		break;
	}

It does nothing if it isn't allocated.

Perhaps we need it to say "(but does not allocate or free)"

-- Steve

Signed-off-by: Wang YanQing <udknight@gmail.com>
---
 I think "Clears and frees" are reasonable, and
 "Clears and allocates are not so reasonable, so
 we don't need to say not allocate. But it is help 
 information, so make it more clearer is also acceptable. :)
 
 kernel/trace/trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 7974ba2..d5f7c4d 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2760,7 +2760,7 @@ static void show_snapshot_main_help(struct seq_file *m)
 	seq_printf(m, "# echo 0 > snapshot : Clears and frees snapshot buffer\n");
 	seq_printf(m, "# echo 1 > snapshot : Allocates snapshot buffer, if not already allocated.\n");
 	seq_printf(m, "#                      Takes a snapshot of the main buffer.\n");
-	seq_printf(m, "# echo 2 > snapshot : Clears snapshot buffer (but does not allocate)\n");
+	seq_printf(m, "# echo 2 > snapshot : Clears snapshot buffer (but does not allocate or free)\n");
 	seq_printf(m, "#                      (Doesn't have to be '2' works with any number that\n");
 	seq_printf(m, "#                       is not a '0' or '1')\n");
 }
-- 
1.7.12.4.dirty

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] trace: show more and exactly help information about snapshot
  2013-09-14  4:59 [PATCH v2] trace: show more and exactly help information about snapshot Wang YanQing
@ 2013-09-14 11:31 ` Steven Rostedt
  0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2013-09-14 11:31 UTC (permalink / raw)
  To: Wang YanQing; +Cc: fweisbec, mingo, linux-kernel

On Sat, 14 Sep 2013 12:59:16 +0800
Wang YanQing <udknight@gmail.com> wrote:

> Actually, they both are correct:
> 
> 	default:
> 		if (tr->allocated_snapshot) {
> 			if (iter->cpu_file == RING_BUFFER_ALL_CPUS)
> 				tracing_reset_online_cpus(&tr->max_buffer);
> 			else
> 				tracing_reset(&tr->max_buffer,	iter->cpu_file);
> 		}
> 		break;
> 	}
> 
> It does nothing if it isn't allocated.
> 
> Perhaps we need it to say "(but does not allocate or free)"
> 
> -- Steve
> 
> Signed-off-by: Wang YanQing <udknight@gmail.com>
> ---
>  I think "Clears and frees" are reasonable, and
>  "Clears and allocates are not so reasonable, so
>  we don't need to say not allocate. But it is help 
>  information, so make it more clearer is also acceptable. :)

I'm getting ready to go to Linux Con / Linux Plumbers. I wont be able to
get to this before, and may not be able to get to it while I'm there.
As the original is technically correct, I'll put this into my 3.13
queue.

Thanks,

-- Steve


>  
>  kernel/trace/trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 7974ba2..d5f7c4d 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2760,7 +2760,7 @@ static void show_snapshot_main_help(struct seq_file *m)
>  	seq_printf(m, "# echo 0 > snapshot : Clears and frees snapshot buffer\n");
>  	seq_printf(m, "# echo 1 > snapshot : Allocates snapshot buffer, if not already allocated.\n");
>  	seq_printf(m, "#                      Takes a snapshot of the main buffer.\n");
> -	seq_printf(m, "# echo 2 > snapshot : Clears snapshot buffer (but does not allocate)\n");
> +	seq_printf(m, "# echo 2 > snapshot : Clears snapshot buffer (but does not allocate or free)\n");
>  	seq_printf(m, "#                      (Doesn't have to be '2' works with any number that\n");
>  	seq_printf(m, "#                       is not a '0' or '1')\n");
>  }


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-14 11:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-14  4:59 [PATCH v2] trace: show more and exactly help information about snapshot Wang YanQing
2013-09-14 11:31 ` Steven Rostedt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.