From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754581Ab3IYIRs (ORCPT ); Wed, 25 Sep 2013 04:17:48 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:33863 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753899Ab3IYIRn (ORCPT ); Wed, 25 Sep 2013 04:17:43 -0400 From: Pali =?utf-8?q?Roh=C3=A1r?= To: balbi@ti.com Subject: Re: [PATCH usb 1/2] usb: musb: Add missing ATOMIC_INIT_NOTIFIER_HEAD Date: Wed, 25 Sep 2013 10:17:38 +0200 User-Agent: KMail/1.13.7 (Linux/3.11.0-1+synaptics-generic; KDE/4.11.1; x86_64; ; ) Cc: Javier Martinez Canillas , Pavel Machek , Tony Lindgren , Anton Vorontsov , Russell King , David Woodhouse , "Greg Kroah-Hartman" , freemangordon@abv.bg, Aaro Koskinen , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux Kernel , linux-usb@vger.kernel.org References: <1378630239-10006-1-git-send-email-pali.rohar@gmail.com> <20130918164816.GN21559@radagast> <201309181903.33243@pali> In-Reply-To: <201309181903.33243@pali> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3714314.3tRJqkthev"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201309251017.39014@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart3714314.3tRJqkthev Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wednesday 18 September 2013 19:03:33 Pali Roh=C3=A1r wrote: > &twl->phy.notifier is not initalized >=20 > Signed-off-by: Pali Roh=C3=A1r >=20 > diff --git a/drivers/usb/phy/phy-twl4030-usb.c > b/drivers/usb/phy/phy-twl4030-usb.c index 8f78d2d..efe6155 > 100644 > --- a/drivers/usb/phy/phy-twl4030-usb.c > +++ b/drivers/usb/phy/phy-twl4030-usb.c > @@ -705,6 +705,8 @@ static int twl4030_usb_probe(struct > platform_device *pdev) if (device_create_file(&pdev->dev, > &dev_attr_vbus)) dev_warn(&pdev->dev, "could not create sysfs > file\n"); >=20 > + ATOMIC_INIT_NOTIFIER_HEAD(&twl->phy.notifier); > + > /* Our job is to use irqs and status from the power module > * to keep the transceiver disabled when nothing's > connected. * I sent above patch week ago. Did you already included it? =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart3714314.3tRJqkthev Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlJCnCIACgkQi/DJPQPkQ1KMzQCeIeAq4podweQ/jVyI4DQTQoV4 nMoAnRLhzlQLdiiPUjkl7/A8L7UNZWFl =qonf -----END PGP SIGNATURE----- --nextPart3714314.3tRJqkthev-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?q?Roh=C3=A1r?= Subject: Re: [PATCH usb 1/2] usb: musb: Add missing ATOMIC_INIT_NOTIFIER_HEAD Date: Wed, 25 Sep 2013 10:17:38 +0200 Message-ID: <201309251017.39014@pali> References: <1378630239-10006-1-git-send-email-pali.rohar@gmail.com> <20130918164816.GN21559@radagast> <201309181903.33243@pali> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3714314.3tRJqkthev"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201309181903.33243@pali> Sender: linux-kernel-owner@vger.kernel.org To: balbi@ti.com Cc: Javier Martinez Canillas , Pavel Machek , Tony Lindgren , Anton Vorontsov , Russell King , David Woodhouse , Greg Kroah-Hartman , freemangordon@abv.bg, Aaro Koskinen , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux Kernel , linux-usb@vger.kernel.org List-Id: linux-omap@vger.kernel.org --nextPart3714314.3tRJqkthev Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wednesday 18 September 2013 19:03:33 Pali Roh=C3=A1r wrote: > &twl->phy.notifier is not initalized >=20 > Signed-off-by: Pali Roh=C3=A1r >=20 > diff --git a/drivers/usb/phy/phy-twl4030-usb.c > b/drivers/usb/phy/phy-twl4030-usb.c index 8f78d2d..efe6155 > 100644 > --- a/drivers/usb/phy/phy-twl4030-usb.c > +++ b/drivers/usb/phy/phy-twl4030-usb.c > @@ -705,6 +705,8 @@ static int twl4030_usb_probe(struct > platform_device *pdev) if (device_create_file(&pdev->dev, > &dev_attr_vbus)) dev_warn(&pdev->dev, "could not create sysfs > file\n"); >=20 > + ATOMIC_INIT_NOTIFIER_HEAD(&twl->phy.notifier); > + > /* Our job is to use irqs and status from the power module > * to keep the transceiver disabled when nothing's > connected. * I sent above patch week ago. Did you already included it? =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart3714314.3tRJqkthev Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlJCnCIACgkQi/DJPQPkQ1KMzQCeIeAq4podweQ/jVyI4DQTQoV4 nMoAnRLhzlQLdiiPUjkl7/A8L7UNZWFl =qonf -----END PGP SIGNATURE----- --nextPart3714314.3tRJqkthev-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: pali.rohar@gmail.com (Pali =?utf-8?q?Roh=C3=A1r?=) Date: Wed, 25 Sep 2013 10:17:38 +0200 Subject: [PATCH usb 1/2] usb: musb: Add missing ATOMIC_INIT_NOTIFIER_HEAD In-Reply-To: <201309181903.33243@pali> References: <1378630239-10006-1-git-send-email-pali.rohar@gmail.com> <20130918164816.GN21559@radagast> <201309181903.33243@pali> Message-ID: <201309251017.39014@pali> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 18 September 2013 19:03:33 Pali Roh?r wrote: > &twl->phy.notifier is not initalized > > Signed-off-by: Pali Roh?r > > diff --git a/drivers/usb/phy/phy-twl4030-usb.c > b/drivers/usb/phy/phy-twl4030-usb.c index 8f78d2d..efe6155 > 100644 > --- a/drivers/usb/phy/phy-twl4030-usb.c > +++ b/drivers/usb/phy/phy-twl4030-usb.c > @@ -705,6 +705,8 @@ static int twl4030_usb_probe(struct > platform_device *pdev) if (device_create_file(&pdev->dev, > &dev_attr_vbus)) dev_warn(&pdev->dev, "could not create sysfs > file\n"); > > + ATOMIC_INIT_NOTIFIER_HEAD(&twl->phy.notifier); > + > /* Our job is to use irqs and status from the power module > * to keep the transceiver disabled when nothing's > connected. * I sent above patch week ago. Did you already included it? -- Pali Roh?r pali.rohar at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: