All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] usb: new board-specific USB init interface
Date: Thu, 26 Sep 2013 03:50:04 +0200	[thread overview]
Message-ID: <201309260350.04523.marex@denx.de> (raw)
In-Reply-To: <5242C26E.2050003@samsung.com>

Dear Mateusz Zalega,

> On 09/19/13 16:34, Marek Vasut wrote:
> > I checked powerpc and "arches" "glacier" and "glacier_nand" don't build.
> > Can you please check and fix ? You can get the ELDK 5.4 PPC toolchain
> > from [1].
> > 
> > http://www.denx.de/wiki/ELDK-5/
> 
> Hello,
> it's because I moved some function declarations and had to include usb.h
> in their code.

Can you please elabore which functions did you exactly move that cause this to 
fail now ?

> @usb.h, this giant ifdef fails:
> 134 #if defined(CONFIG_USB_UHCI) || defined(CONFIG_USB_OHCI) || \
> 135         defined(CONFIG_USB_EHCI) || defined(CONFIG_USB_OHCI_NEW) || \
> 136         defined(CONFIG_USB_SL811HS) ||
> defined(CONFIG_USB_ISP116X_HCD) || \
> 137         defined(CONFIG_USB_R8A66597_HCD) ||
> defined(CONFIG_USB_DAVINCI) || \
> 138         defined(CONFIG_USB_OMAP3) || defined(CONFIG_USB_DA8XX) || \
> 139         defined(CONFIG_USB_BLACKFIN) || defined(CONFIG_USB_AM35X) || \
> 140         defined(CONFIG_USB_MUSB_DSPS) ||
> defined(CONFIG_USB_MUSB_AM35X) || \
> 141         defined(CONFIG_USB_MUSB_OMAP2PLUS)
> 
> and results in:
> 169 #error USB Lowlevel not defined
> 
> I don't like the notion of using board-specific CONFIG_* defines in
> usb.h. Any ideas on where can we move it? Maybe one generic
> CONFIG_USB_HOST specified in board code would do?

The ifdef is pretty much what would CONFIG_USB_HOST do.

Best regards,
Marek Vasut

  reply	other threads:[~2013-09-26  1:50 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-06 10:50 [U-Boot] [RFC 00/10] New board-specific USB initialization interface Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 01/10] " Mateusz Zalega
2013-08-07 16:23   ` Stephen Warren
2013-08-11 18:04   ` Marek Vasut
2013-08-12  9:33     ` Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 02/10] nvidia, tegra: new USB hardware init interface Mateusz Zalega
2013-08-07 16:26   ` Stephen Warren
2013-08-06 10:50 ` [U-Boot] [RFC 03/10] Voipac PXA270: " Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 04/10] Trizeps IV: " Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 05/10] Colibri PXA270: " Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 06/10] icpdas lp8x4x: " Mateusz Zalega
2013-08-11 18:07   ` Marek Vasut
2013-08-06 10:50 ` [U-Boot] [RFC 07/10] esd pmc440: " Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 08/10] esd apc405: " Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 09/10] balloon3: " Mateusz Zalega
2013-08-06 10:50 ` [U-Boot] [RFC 10/10] canyonlands: " Mateusz Zalega
2013-08-06 11:40 ` [U-Boot] [RFC 00/10] New board-specific USB initialization interface Wolfgang Denk
2013-08-07 15:57   ` Mateusz Zalega
2013-08-07 16:59     ` Mateusz Zalega
2013-08-07 17:01     ` Wolfgang Denk
2013-08-20 13:35 ` [U-Boot] [PATCH] usb: new board-specific USB init interface Mateusz Zalega
2013-08-21  3:33   ` Marek Vasut
2013-08-21 10:22     ` Mateusz Zalega
2013-08-21 13:08       ` Marek Vasut
2013-08-22 10:32         ` Mateusz Zalega
2013-08-22 19:37           ` Marek Vasut
2013-08-26 10:41             ` Mateusz Zalega
2013-08-27 19:50               ` Marek Vasut
2013-08-21  8:33 ` [U-Boot] [PATCH v2] " Mateusz Zalega
2013-08-27 15:51   ` Mateusz Zalega
2013-09-03 10:41 ` [U-Boot] [PATCH v3] " Mateusz Zalega
2013-09-05 15:50   ` Marek Vasut
2013-09-05 17:37     ` Mateusz Zalega
2013-09-05 17:51       ` Marek Vasut
2013-09-06 11:22         ` Mateusz Zalega
2013-09-06 11:24           ` Marek Vasut
2013-09-06 11:36             ` Mateusz Zalega
2013-09-06 11:40               ` Marek Vasut
2013-09-06 12:17                 ` Mateusz Zalega
2013-09-15 14:21                   ` Marek Vasut
2013-09-16  8:27                     ` Mateusz Zalega
2013-09-10 15:10 ` [U-Boot] [PATCH v4] " Mateusz Zalega
2013-09-15 16:44   ` Marek Vasut
2013-09-16  9:10     ` Mateusz Zalega
2013-09-16 14:24       ` Marek Vasut
2013-09-17 16:11   ` Igor Grinberg
2013-09-18 10:58     ` Mateusz Zalega
2013-09-19 13:34   ` Marek Vasut
2013-09-19 13:40     ` Marek Vasut
2013-09-19 14:34       ` Marek Vasut
2013-09-24 11:54         ` Minkyu Kang
2013-09-24 13:15           ` Marek Vasut
2013-09-25 11:01         ` Mateusz Zalega
2013-09-26  1:50           ` Marek Vasut [this message]
2013-09-26 10:04             ` Mateusz Zalega
2013-10-02 19:11 ` [U-Boot] [PATCH v5] " Mateusz Zalega
2013-10-03 15:16   ` Marek Vasut
2013-10-04 17:22 ` [U-Boot] [PATCH v6] " Mateusz Zalega
2013-10-05  0:48   ` Troy Kisky
2013-10-07 10:32     ` Mateusz Zalega
2013-10-08  0:09       ` Troy Kisky
2013-10-08 10:31         ` Marek Vasut
2013-10-06 13:55   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201309260350.04523.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.