From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752231Ab3JDWa2 (ORCPT ); Fri, 4 Oct 2013 18:30:28 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:54183 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988Ab3JDWaZ (ORCPT ); Fri, 4 Oct 2013 18:30:25 -0400 Date: Fri, 4 Oct 2013 15:30:18 -0700 From: Guenter Roeck To: Boris BREZILLON Cc: Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Russell King , Wim Van Sebroeck , Fabio Porcedda , Nicolas Ferre , Guenter Roeck , Yang Wenyou , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH v5 1/4] watchdog: at91sam9_wdt: better watchdog support Message-ID: <20131004223018.GA3685@roeck-us.net> References: <1380871455-7324-1-git-send-email-b.brezillon@overkiz.com> <1380871455-7324-2-git-send-email-b.brezillon@overkiz.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1380871455-7324-2-git-send-email-b.brezillon@overkiz.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 04, 2013 at 09:24:12AM +0200, Boris BREZILLON wrote: > The at91sam9 watchdog timer can only be configured once, and the current > implementation tries to configure it in a static way: > - 2 seconds timeout > - wdt restart every 500ms > > If the timer has already been configured with different values, it returns an > error and do not create any watchdog device. > > This is not critical if the watchdog is disabled, but if it has been enabled with > different timeout values it will lead to a SoC reset. > > This patch series tries to address this issue by adapting the heartbeat value > according the WDT timer config: > - it first tries to configure the timer as requested. > - if it fails it fallbacks to the current config, adapting its heartbeat timer > to the needs > > This patch series also move to a dynamically allocated at91wdt device instead > of the static instance. > > It adds a new at91 wdt type: software. This new type make use of the at91 wdt > interrupt to trigger a software reboot. > > Finally it adds several properties to the device tree bindings. > > Signed-off-by: Boris BREZILLON Reviewed-by: Guenter Roeck From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v5 1/4] watchdog: at91sam9_wdt: better watchdog support Date: Fri, 4 Oct 2013 15:30:18 -0700 Message-ID: <20131004223018.GA3685@roeck-us.net> References: <1380871455-7324-1-git-send-email-b.brezillon@overkiz.com> <1380871455-7324-2-git-send-email-b.brezillon@overkiz.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1380871455-7324-2-git-send-email-b.brezillon-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Boris BREZILLON Cc: Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Russell King , Wim Van Sebroeck , Fabio Porcedda , Nicolas Ferre , Guenter Roeck , Yang Wenyou , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Oct 04, 2013 at 09:24:12AM +0200, Boris BREZILLON wrote: > The at91sam9 watchdog timer can only be configured once, and the current > implementation tries to configure it in a static way: > - 2 seconds timeout > - wdt restart every 500ms > > If the timer has already been configured with different values, it returns an > error and do not create any watchdog device. > > This is not critical if the watchdog is disabled, but if it has been enabled with > different timeout values it will lead to a SoC reset. > > This patch series tries to address this issue by adapting the heartbeat value > according the WDT timer config: > - it first tries to configure the timer as requested. > - if it fails it fallbacks to the current config, adapting its heartbeat timer > to the needs > > This patch series also move to a dynamically allocated at91wdt device instead > of the static instance. > > It adds a new at91 wdt type: software. This new type make use of the at91 wdt > interrupt to trigger a software reboot. > > Finally it adds several properties to the device tree bindings. > > Signed-off-by: Boris BREZILLON Reviewed-by: Guenter Roeck -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@roeck-us.net (Guenter Roeck) Date: Fri, 4 Oct 2013 15:30:18 -0700 Subject: [PATCH v5 1/4] watchdog: at91sam9_wdt: better watchdog support In-Reply-To: <1380871455-7324-2-git-send-email-b.brezillon@overkiz.com> References: <1380871455-7324-1-git-send-email-b.brezillon@overkiz.com> <1380871455-7324-2-git-send-email-b.brezillon@overkiz.com> Message-ID: <20131004223018.GA3685@roeck-us.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Oct 04, 2013 at 09:24:12AM +0200, Boris BREZILLON wrote: > The at91sam9 watchdog timer can only be configured once, and the current > implementation tries to configure it in a static way: > - 2 seconds timeout > - wdt restart every 500ms > > If the timer has already been configured with different values, it returns an > error and do not create any watchdog device. > > This is not critical if the watchdog is disabled, but if it has been enabled with > different timeout values it will lead to a SoC reset. > > This patch series tries to address this issue by adapting the heartbeat value > according the WDT timer config: > - it first tries to configure the timer as requested. > - if it fails it fallbacks to the current config, adapting its heartbeat timer > to the needs > > This patch series also move to a dynamically allocated at91wdt device instead > of the static instance. > > It adds a new at91 wdt type: software. This new type make use of the at91 wdt > interrupt to trigger a software reboot. > > Finally it adds several properties to the device tree bindings. > > Signed-off-by: Boris BREZILLON Reviewed-by: Guenter Roeck