From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Mon, 7 Oct 2013 12:48:20 +0200 Subject: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver In-Reply-To: <20131007094404.GI12758@n2100.arm.linux.org.uk> References: <20131006220728.GG12758@n2100.arm.linux.org.uk> <20131007111807.5e86ea6e@armhf> <20131007094404.GI12758@n2100.arm.linux.org.uk> Message-ID: <20131007124820.2189a4c3@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 7 Oct 2013 10:44:04 +0100 Russell King - ARM Linux wrote: > On Mon, Oct 07, 2013 at 11:18:07AM +0200, Jean-Francois Moine wrote: [snip] > > It seems we are going backwards: as the Armada based boards will soon > > move to full DT (mvebu), you are making an exception for the Cubox, so > > that there should be Cubox specific kernels. I don't like that... > > *Ignored*. You know why. Sorry. I don't see why. May you explain again? > > > diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c [snip] > > > +static struct tda998x_encoder_params params = { > > > + /* With 0x24, there is no translation between vp_out and int_vp > > > + FB LCD out Pins VIP Int Vp > > > + R:23:16 R:7:0 VPC7:0 7:0 7:0[R] > > > + G:15:8 G:15:8 VPB7:0 23:16 23:16[G] > > > + B:7:0 B:23:16 VPA7:0 15:8 15:8[B] > > > + */ > > > + .swap_a = 2, > > > + .swap_b = 3, > > > + .swap_c = 4, > > > + .swap_d = 5, > > > + .swap_e = 0, > > > + .swap_f = 1, > > > > I still don't agree. You don't need to invert R <-> B for the Cubox at > > the tda998x level: this may be done setting as it should be the > > CFG_GRA_SWAPRB flag of the lcd register LCD_SPU_DMA_CTRL0. > > You are totally and utterly wrong there. We need R and B presented on > their correct lanes to the TDA998x so that the Armadas YUV->RGB > conversion works. Setting CFG_GRA_SWAPRB does not swap the YUV output > to match, neither does setting any of the other bits. > > CFG_GRA_SWAPRB is all about the _graphics_ _framebuffer_ format, it's got > nothing to do at all with how the output is wired. Then, may you explain why you must swap R/B on simple RGB output? >>From your [PATCH 2/5] DRM: Armada: Add Armada DRM driver: + FMT(RGB888, 888PACK, CFG_SWAPRB); + FMT(BGR888, 888PACK, 0); + FMT(YUYV, 422PACK, CFG_YUV2RGB | CFG_SWAPYU | CFG_SWAPUV); > > > + .audio_cfg = BIT(2), > > > + .audio_frame[1] = 1, > > > + .audio_format = AFMT_SPDIF, > > > + .audio_sample_rate = 44100, > > > > These values are rather mysterious! > > Also I'm going to ignore this comment, because quite honestly, I think > this is worthless. You haven't investigated how the TDA998x actually > gets setup by Rabeeh. Rabeeh did the most he could to have a working Cubox. He used bad written drivers and he had not the time to think about how the drivers could be enhanced. Here is a small story about i2s/spdif: once, I set the tda998x to use the spdif input, and at this time, I was using the dummy codec. This codec accepts the format 32_LE, as does the audio device, but the output cannot go to spdif. Result: no hdmi sound. Should we restrict the hdmi transmitter to spdif (thus 'no 32 bits stream') or to i2s (thus 'no compressed stream') only, or accept both i2s and spdif and allow a full range of supported audio streams? -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ + From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver Date: Mon, 7 Oct 2013 12:48:20 +0200 Message-ID: <20131007124820.2189a4c3@armhf> References: <20131006220728.GG12758@n2100.arm.linux.org.uk> <20131007111807.5e86ea6e@armhf> <20131007094404.GI12758@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp4-g21.free.fr (smtp4-g21.free.fr [212.27.42.4]) by gabe.freedesktop.org (Postfix) with ESMTP id 265C3E70E1 for ; Mon, 7 Oct 2013 03:44:58 -0700 (PDT) In-Reply-To: <20131007094404.GI12758@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Russell King - ARM Linux Cc: Jason Cooper , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCA3IE9jdCAyMDEzIDEwOjQ0OjA0ICswMTAwClJ1c3NlbGwgS2luZyAtIEFSTSBMaW51 eCA8bGludXhAYXJtLmxpbnV4Lm9yZy51az4gd3JvdGU6Cgo+IE9uIE1vbiwgT2N0IDA3LCAyMDEz IGF0IDExOjE4OjA3QU0gKzAyMDAsIEplYW4tRnJhbmNvaXMgTW9pbmUgd3JvdGU6Cglbc25pcF0K PiA+IEl0IHNlZW1zIHdlIGFyZSBnb2luZyBiYWNrd2FyZHM6IGFzIHRoZSBBcm1hZGEgYmFzZWQg Ym9hcmRzIHdpbGwgc29vbgo+ID4gbW92ZSB0byBmdWxsIERUIChtdmVidSksIHlvdSBhcmUgbWFr aW5nIGFuIGV4Y2VwdGlvbiBmb3IgdGhlIEN1Ym94LCBzbwo+ID4gdGhhdCB0aGVyZSBzaG91bGQg YmUgQ3Vib3ggc3BlY2lmaWMga2VybmVscy4gSSBkb24ndCBsaWtlIHRoYXQuLi4KPiAKPiAqSWdu b3JlZCouICBZb3Uga25vdyB3aHkuCgpTb3JyeS4gSSBkb24ndCBzZWUgd2h5LiBNYXkgeW91IGV4 cGxhaW4gYWdhaW4/Cgo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FybWFkYS9h cm1hZGFfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vYXJtYWRhL2FybWFkYV9kcnYuYwoJW3NuaXBd Cj4gPiA+ICtzdGF0aWMgc3RydWN0IHRkYTk5OHhfZW5jb2Rlcl9wYXJhbXMgcGFyYW1zID0gewo+ ID4gPiArCS8qIFdpdGggMHgyNCwgdGhlcmUgaXMgbm8gdHJhbnNsYXRpb24gYmV0d2VlbiB2cF9v dXQgYW5kIGludF92cAo+ID4gPiArCUZCCUxDRCBvdXQJUGlucwlWSVAJSW50IFZwCj4gPiA+ICsJ UjoyMzoxNglSOjc6MAlWUEM3OjAJNzowCTc6MFtSXQo+ID4gPiArCUc6MTU6OAlHOjE1OjgJVlBC NzowCTIzOjE2CTIzOjE2W0ddCj4gPiA+ICsJQjo3OjAJQjoyMzoxNglWUEE3OjAJMTU6OAkxNTo4 W0JdCj4gPiA+ICsJKi8KPiA+ID4gKwkuc3dhcF9hID0gMiwKPiA+ID4gKwkuc3dhcF9iID0gMywK PiA+ID4gKwkuc3dhcF9jID0gNCwKPiA+ID4gKwkuc3dhcF9kID0gNSwKPiA+ID4gKwkuc3dhcF9l ID0gMCwKPiA+ID4gKwkuc3dhcF9mID0gMSwKPiA+IAo+ID4gSSBzdGlsbCBkb24ndCBhZ3JlZS4g WW91IGRvbid0IG5lZWQgdG8gaW52ZXJ0IFIgPC0+IEIgZm9yIHRoZSBDdWJveCBhdAo+ID4gdGhl IHRkYTk5OHggbGV2ZWw6IHRoaXMgbWF5IGJlIGRvbmUgc2V0dGluZyBhcyBpdCBzaG91bGQgYmUg dGhlCj4gPiBDRkdfR1JBX1NXQVBSQiBmbGFnIG9mIHRoZSBsY2QgcmVnaXN0ZXIgTENEX1NQVV9E TUFfQ1RSTDAuCj4gCj4gWW91IGFyZSB0b3RhbGx5IGFuZCB1dHRlcmx5IHdyb25nIHRoZXJlLiAg V2UgbmVlZCBSIGFuZCBCIHByZXNlbnRlZCBvbgo+IHRoZWlyIGNvcnJlY3QgbGFuZXMgdG8gdGhl IFREQTk5OHggc28gdGhhdCB0aGUgQXJtYWRhcyBZVVYtPlJHQgo+IGNvbnZlcnNpb24gd29ya3Mu ICBTZXR0aW5nIENGR19HUkFfU1dBUFJCIGRvZXMgbm90IHN3YXAgdGhlIFlVViBvdXRwdXQKPiB0 byBtYXRjaCwgbmVpdGhlciBkb2VzIHNldHRpbmcgYW55IG9mIHRoZSBvdGhlciBiaXRzLgo+IAo+ IENGR19HUkFfU1dBUFJCIGlzIGFsbCBhYm91dCB0aGUgX2dyYXBoaWNzXyBfZnJhbWVidWZmZXJf IGZvcm1hdCwgaXQncyBnb3QKPiBub3RoaW5nIHRvIGRvIGF0IGFsbCB3aXRoIGhvdyB0aGUgb3V0 cHV0IGlzIHdpcmVkLgoKVGhlbiwgbWF5IHlvdSBleHBsYWluIHdoeSB5b3UgbXVzdCBzd2FwIFIv QiBvbiBzaW1wbGUgUkdCIG91dHB1dD8KCkZyb20geW91ciBbUEFUQ0ggMi81XSBEUk06IEFybWFk YTogQWRkIEFybWFkYSBEUk0gZHJpdmVyOgoKKwlGTVQoUkdCODg4LAk4ODhQQUNLLAlDRkdfU1dB UFJCKTsKKwlGTVQoQkdSODg4LAk4ODhQQUNLLAkwKTsKCisJRk1UKFlVWVYsCTQyMlBBQ0ssCUNG R19ZVVYyUkdCIHwgQ0ZHX1NXQVBZVSB8IENGR19TV0FQVVYpOwoKPiA+ID4gKwkuYXVkaW9fY2Zn ID0gQklUKDIpLAo+ID4gPiArCS5hdWRpb19mcmFtZVsxXSA9IDEsCj4gPiA+ICsJLmF1ZGlvX2Zv cm1hdCA9IEFGTVRfU1BESUYsCj4gPiA+ICsJLmF1ZGlvX3NhbXBsZV9yYXRlID0gNDQxMDAsCj4g PiAKPiA+IFRoZXNlIHZhbHVlcyBhcmUgcmF0aGVyIG15c3RlcmlvdXMhCj4gCj4gQWxzbyBJJ20g Z29pbmcgdG8gaWdub3JlIHRoaXMgY29tbWVudCwgYmVjYXVzZSBxdWl0ZSBob25lc3RseSwgSSB0 aGluawo+IHRoaXMgaXMgd29ydGhsZXNzLiAgWW91IGhhdmVuJ3QgaW52ZXN0aWdhdGVkIGhvdyB0 aGUgVERBOTk4eCBhY3R1YWxseQo+IGdldHMgc2V0dXAgYnkgUmFiZWVoLgoKUmFiZWVoIGRpZCB0 aGUgbW9zdCBoZSBjb3VsZCB0byBoYXZlIGEgd29ya2luZyBDdWJveC4gSGUgdXNlZCBiYWQKd3Jp dHRlbiBkcml2ZXJzIGFuZCBoZSBoYWQgbm90IHRoZSB0aW1lIHRvIHRoaW5rIGFib3V0IGhvdyB0 aGUgZHJpdmVycwpjb3VsZCBiZSBlbmhhbmNlZC4KCkhlcmUgaXMgYSBzbWFsbCBzdG9yeSBhYm91 dCBpMnMvc3BkaWY6IG9uY2UsIEkgc2V0IHRoZSB0ZGE5OTh4IHRvIHVzZQp0aGUgc3BkaWYgaW5w dXQsIGFuZCBhdCB0aGlzIHRpbWUsIEkgd2FzIHVzaW5nIHRoZSBkdW1teSBjb2RlYy4KVGhpcyBj b2RlYyBhY2NlcHRzIHRoZSBmb3JtYXQgMzJfTEUsIGFzIGRvZXMgdGhlIGF1ZGlvIGRldmljZSwg YnV0IHRoZQpvdXRwdXQgY2Fubm90IGdvIHRvIHNwZGlmLiBSZXN1bHQ6IG5vIGhkbWkgc291bmQu CgpTaG91bGQgd2UgcmVzdHJpY3QgdGhlIGhkbWkgdHJhbnNtaXR0ZXIgdG8gc3BkaWYgKHRodXMg J25vIDMyIGJpdHMKc3RyZWFtJykgb3IgdG8gaTJzICh0aHVzICdubyBjb21wcmVzc2VkIHN0cmVh bScpIG9ubHksIG9yIGFjY2VwdCBib3RoCmkycyBhbmQgc3BkaWYgYW5kIGFsbG93IGEgZnVsbCBy YW5nZSBvZiBzdXBwb3J0ZWQgYXVkaW8gc3RyZWFtcz8KCi0tIApLZW4gYXIgYydoZW50YcOxCXwJ ICAgICAgKiogQnJlaXpoIGhhIExpbnV4IGF0YXYhICoqCkplZgkJfAkJaHR0cDovL21vaW5lamYu ZnJlZS5mci8KKwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=