From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Mon, 7 Oct 2013 14:03:27 +0200 Subject: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver In-Reply-To: <20131007110902.GL12758@n2100.arm.linux.org.uk> References: <20131006220728.GG12758@n2100.arm.linux.org.uk> <20131007111807.5e86ea6e@armhf> <20131007094404.GI12758@n2100.arm.linux.org.uk> <20131007124820.2189a4c3@armhf> <20131007110902.GL12758@n2100.arm.linux.org.uk> Message-ID: <20131007140327.5bb4863b@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 7 Oct 2013 12:09:02 +0100 Russell King - ARM Linux wrote: > > Here is a small story about i2s/spdif: once, I set the tda998x to use > > the spdif input, and at this time, I was using the dummy codec. > > This codec accepts the format 32_LE, as does the audio device, but the > > output cannot go to spdif. Result: no hdmi sound. > > How ASoC works in this regard is that the capabilities are the _union_ of > the codec and the cpu DAIs. > > The SPDIF transmitter codec supports 16, 20 and 24 bits per sample but not > 32. Quite simply, that's because the SPDIF format does not allow 32-bits > per sample. Therefore, 32_LE is not available for use with audio output, > and userspace must convert down to something which the hardware does > support. > > "Because I2S can support 32-bit audio" is a poor reason, because you can't > pass 32-bit audio via HDMI due to a subframe being limited to 28 bits - up > to 24 bits for the sample and 4 bits of control/status information. OK. So, to resume, if both i2s and spdif are furnished by the audio subsystem, the tda998x must use spdif only (with the spdif codec). Then, the declaration of the tda998x in the DT will include an optional audio property, say 'audio-input' with the values "i2s" or "spdif" which corresponds to your parameter 'audio_format'. Also, from your video swap explanation, the DT will contain some video property(ies) TBD. The remaining question is: do we need more audio parameters? - the audio_cfg value is defined by i2s/spdif (3 or 4) - the audio_frame[1] value is always 1 (2 channels) - audio_sample_rate is useless -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver Date: Mon, 7 Oct 2013 14:03:27 +0200 Message-ID: <20131007140327.5bb4863b@armhf> References: <20131006220728.GG12758@n2100.arm.linux.org.uk> <20131007111807.5e86ea6e@armhf> <20131007094404.GI12758@n2100.arm.linux.org.uk> <20131007124820.2189a4c3@armhf> <20131007110902.GL12758@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20131007110902.GL12758@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Russell King - ARM Linux Cc: Jason Cooper , David Airlie , dri-devel@lists.freedesktop.org, Rob Clark , Daniel Vetter , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCA3IE9jdCAyMDEzIDEyOjA5OjAyICswMTAwClJ1c3NlbGwgS2luZyAtIEFSTSBMaW51 eCA8bGludXhAYXJtLmxpbnV4Lm9yZy51az4gd3JvdGU6Cgo+ID4gSGVyZSBpcyBhIHNtYWxsIHN0 b3J5IGFib3V0IGkycy9zcGRpZjogb25jZSwgSSBzZXQgdGhlIHRkYTk5OHggdG8gdXNlCj4gPiB0 aGUgc3BkaWYgaW5wdXQsIGFuZCBhdCB0aGlzIHRpbWUsIEkgd2FzIHVzaW5nIHRoZSBkdW1teSBj b2RlYy4KPiA+IFRoaXMgY29kZWMgYWNjZXB0cyB0aGUgZm9ybWF0IDMyX0xFLCBhcyBkb2VzIHRo ZSBhdWRpbyBkZXZpY2UsIGJ1dCB0aGUKPiA+IG91dHB1dCBjYW5ub3QgZ28gdG8gc3BkaWYuIFJl c3VsdDogbm8gaGRtaSBzb3VuZC4gIAo+IAo+IEhvdyBBU29DIHdvcmtzIGluIHRoaXMgcmVnYXJk IGlzIHRoYXQgdGhlIGNhcGFiaWxpdGllcyBhcmUgdGhlIF91bmlvbl8gb2YKPiB0aGUgY29kZWMg YW5kIHRoZSBjcHUgREFJcy4KPiAKPiBUaGUgU1BESUYgdHJhbnNtaXR0ZXIgY29kZWMgc3VwcG9y dHMgMTYsIDIwIGFuZCAyNCBiaXRzIHBlciBzYW1wbGUgYnV0IG5vdAo+IDMyLiAgUXVpdGUgc2lt cGx5LCB0aGF0J3MgYmVjYXVzZSB0aGUgU1BESUYgZm9ybWF0IGRvZXMgbm90IGFsbG93IDMyLWJp dHMKPiBwZXIgc2FtcGxlLiAgVGhlcmVmb3JlLCAzMl9MRSBpcyBub3QgYXZhaWxhYmxlIGZvciB1 c2Ugd2l0aCBhdWRpbyBvdXRwdXQsCj4gYW5kIHVzZXJzcGFjZSBtdXN0IGNvbnZlcnQgZG93biB0 byBzb21ldGhpbmcgd2hpY2ggdGhlIGhhcmR3YXJlIGRvZXMKPiBzdXBwb3J0Lgo+IAo+ICJCZWNh dXNlIEkyUyBjYW4gc3VwcG9ydCAzMi1iaXQgYXVkaW8iIGlzIGEgcG9vciByZWFzb24sIGJlY2F1 c2UgeW91IGNhbid0Cj4gcGFzcyAzMi1iaXQgYXVkaW8gdmlhIEhETUkgZHVlIHRvIGEgc3ViZnJh bWUgYmVpbmcgbGltaXRlZCB0byAyOCBiaXRzIC0gdXAKPiB0byAyNCBiaXRzIGZvciB0aGUgc2Ft cGxlIGFuZCA0IGJpdHMgb2YgY29udHJvbC9zdGF0dXMgaW5mb3JtYXRpb24uCgpPSy4gU28sIHRv IHJlc3VtZSwgaWYgYm90aCBpMnMgYW5kIHNwZGlmIGFyZSBmdXJuaXNoZWQgYnkgdGhlIGF1ZGlv CnN1YnN5c3RlbSwgdGhlIHRkYTk5OHggbXVzdCB1c2Ugc3BkaWYgb25seSAod2l0aCB0aGUgc3Bk aWYgY29kZWMpLgoKVGhlbiwgdGhlIGRlY2xhcmF0aW9uIG9mIHRoZSB0ZGE5OTh4IGluIHRoZSBE VCB3aWxsIGluY2x1ZGUgYW4Kb3B0aW9uYWwgYXVkaW8gcHJvcGVydHksIHNheSAnYXVkaW8taW5w dXQnIHdpdGggdGhlIHZhbHVlcyAiaTJzIiBvcgoic3BkaWYiIHdoaWNoIGNvcnJlc3BvbmRzIHRv IHlvdXIgcGFyYW1ldGVyICdhdWRpb19mb3JtYXQnLgoKQWxzbywgZnJvbSB5b3VyIHZpZGVvIHN3 YXAgZXhwbGFuYXRpb24sIHRoZSBEVCB3aWxsIGNvbnRhaW4gc29tZSB2aWRlbwpwcm9wZXJ0eShp ZXMpIFRCRC4KClRoZSByZW1haW5pbmcgcXVlc3Rpb24gaXM6IGRvIHdlIG5lZWQgbW9yZSBhdWRp byBwYXJhbWV0ZXJzPwoKLSB0aGUgYXVkaW9fY2ZnIHZhbHVlIGlzIGRlZmluZWQgYnkgaTJzL3Nw ZGlmICgzIG9yIDQpCi0gdGhlIGF1ZGlvX2ZyYW1lWzFdIHZhbHVlIGlzIGFsd2F5cyAxICgyIGNo YW5uZWxzKQotIGF1ZGlvX3NhbXBsZV9yYXRlIGlzIHVzZWxlc3MKCi0tIApLZW4gYXIgYydoZW50 YcOxCXwJICAgICAgKiogQnJlaXpoIGhhIExpbnV4IGF0YXYhICoqCkplZgkJfAkJaHR0cDovL21v aW5lamYuZnJlZS5mci8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK