From: Dave Jones <davej@redhat.com>
To: Ildar Muslukhov <ildarm@google.com>
Cc: trinity@vger.kernel.org
Subject: Re: [PATCH 5/6] added bufferless logging functions for syscall pamaters
Date: Wed, 9 Oct 2013 12:27:25 -0400 [thread overview]
Message-ID: <20131009162725.GB2821@redhat.com> (raw)
In-Reply-To: <1381267615-9826-5-git-send-email-ildarm@google.com>
On Tue, Oct 08, 2013 at 02:26:54PM -0700, Ildar Muslukhov wrote:
> +static void output_arg(unsigned int call, unsigned int argnum, const char *name, unsigned long oldreg, unsigned long reg, int type, FILE *fd, bool mono)
> +{
> +}
> +
uh, what ?
> +
> +static void output_syscall_prefix_to_fd(const unsigned int childno, const pid_t pid, const unsigned int syscallno, FILE *fd, bool mono)
> +{
> + fprintf(fd, "[child%d:%d] [%ld] %s", childno, pid, shm->child_syscall_count[childno],
> + (shm->do32bit[childno] == TRUE) ? "[32BIT] " : "");
> +
> + if (syscallno > max_nr_syscalls)
> + fprintf(fd, "%u", syscallno);
> + else
> + fprintf(fd, "%s", syscalls[syscallno].entry->name);
> +
> + CRESETFD
> + fprintf(fd, "(");
> + output_arg(syscallno, 1, syscalls[syscallno].entry->arg1name, shm->previous_a1[childno], shm->a1[childno],
> + syscalls[syscallno].entry->arg1type, fd, mono);
> + output_arg(syscallno, 2, syscalls[syscallno].entry->arg2name, shm->previous_a2[childno], shm->a2[childno],
> + syscalls[syscallno].entry->arg2type, fd, mono);
> + output_arg(syscallno, 3, syscalls[syscallno].entry->arg3name, shm->previous_a3[childno], shm->a3[childno],
> + syscalls[syscallno].entry->arg3type, fd, mono);
> + output_arg(syscallno, 4, syscalls[syscallno].entry->arg4name, shm->previous_a4[childno], shm->a4[childno],
> + syscalls[syscallno].entry->arg4type, fd, mono);
> + output_arg(syscallno, 5, syscalls[syscallno].entry->arg5name, shm->previous_a5[childno], shm->a5[childno],
> + syscalls[syscallno].entry->arg5type, fd, mono);
> + output_arg(syscallno, 6, syscalls[syscallno].entry->arg6name, shm->previous_a6[childno], shm->a6[childno],
> + syscalls[syscallno].entry->arg6type, fd, mono);
> + CRESETFD
> + fprintf(fd, ") ");
> +}
Dave
next prev parent reply other threads:[~2013-10-09 16:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 21:26 [PATCH 1/6] added outputerr/outputstd log functions Ildar Muslukhov
2013-10-08 21:26 ` [PATCH 2/6] wired outputstd/err functions Ildar Muslukhov
2013-10-08 21:26 ` [PATCH 3/6] refactored output function Ildar Muslukhov
2013-10-10 18:20 ` Dave Jones
2013-10-15 17:07 ` Ildar Muslukhov
2013-10-08 21:26 ` [PATCH 4/6] wired in output function instead of printf (and some missing outputstd) Ildar Muslukhov
2013-10-09 16:23 ` Dave Jones
2013-10-09 21:40 ` Dave Jones
2013-10-08 21:26 ` [PATCH 5/6] added bufferless logging functions for syscall pamaters Ildar Muslukhov
2013-10-09 16:27 ` Dave Jones [this message]
2013-10-08 21:26 ` [PATCH 6/6] wired syscall parameters logging function into syscall (this should fix stack smash bug detected) Ildar Muslukhov
2013-10-09 16:28 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009162725.GB2821@redhat.com \
--to=davej@redhat.com \
--cc=ildarm@google.com \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.