From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH QEMU-upstream] Fix build errors when enabling extra logging with #define DEBUG_XEN and #define XEN_PT_LOGGING_ENABLED Date: Wed, 9 Oct 2013 18:02:00 +0100 Message-ID: <20131009170200.GQ28411@zion.uk.xensource.com> References: <1381336440-30745-1-git-send-email-linux@eikelenboom.it> <20131009165657.GP28411@zion.uk.xensource.com> <566800526.20131009185841@eikelenboom.it> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <566800526.20131009185841@eikelenboom.it> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Sander Eikelenboom Cc: Stefano Stabellini , Wei Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, Oct 09, 2013 at 06:58:41PM +0200, Sander Eikelenboom wrote: > > Wednesday, October 9, 2013, 6:56:57 PM, you wrote: > > > On Wed, Oct 09, 2013 at 06:34:00PM +0200, Sander Eikelenboom wrote: > >> > >> Signed-off-by: Sander Eikelenboom > >> --- > >> hw/xen/xen_pt.c | 2 +- > >> xen-all.c | 2 +- > >> 2 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > >> index ca2d460..3521e36 100644 > >> --- a/hw/xen/xen_pt.c > >> +++ b/hw/xen/xen_pt.c > >> @@ -570,7 +570,7 @@ static void xen_pt_region_update(XenPCIPassthroughState *s, > >> if (args.rc) { > >> XEN_PT_WARN(d, "Region: %d (addr: %#"FMT_PCIBUS > >> ", len: %#"FMT_PCIBUS") is overlapped.\n", > >> - bar, sec->offset_within_address_space, sec->size); > >> + bar, sec->offset_within_address_space, int128_get64(sec->size)); > > > Why is this needed? Isn't sec->size of type uint64? > > Nope it's uint128 since http://lists.nongnu.org/archive/html/qemu-devel/2013-06/msg03612.html > Time to refresh me tree. Thanks! :-) Wei.