From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: don't leak dp_connector at intel_ddi_init Date: Wed, 9 Oct 2013 19:25:17 +0200 Message-ID: <20131009172517.GQ8303@phenom.ffwll.local> References: <1381337556-1596-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f179.google.com (mail-ea0-f179.google.com [209.85.215.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 159EAE7C55 for ; Wed, 9 Oct 2013 10:24:58 -0700 (PDT) Received: by mail-ea0-f179.google.com with SMTP id b10so565862eae.24 for ; Wed, 09 Oct 2013 10:24:58 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1381337556-1596-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 09, 2013 at 01:52:36PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Regression introduced by: > commit 311a20949f047a70935d6591010f42336f5402e7 > Author: Paulo Zanoni > drm/i915: don't init DP or HDMI when not supported by DDI port > > Since the commit above it is possible to have a DDI encoder that has > the HDMI connector but not the DP connector (in case the port doesn't > support DP). In this case, we must properly free the DP connector. > > We just leak this once, so it's not a big deal. > > Reported by kmemleak. > > Signed-off-by: Paulo Zanoni Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch