From: Greg KH <gregkh@linuxfoundation.org>
To: Ben Myers <bpm@sgi.com>
Cc: stable@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix node forward in xfs_node_toosmall
Date: Thu, 10 Oct 2013 16:02:02 -0700 [thread overview]
Message-ID: <20131010230202.GC4301@kroah.com> (raw)
In-Reply-To: <20131009000926.GI10553@sgi.com>
On Tue, Oct 08, 2013 at 07:09:26PM -0500, Ben Myers wrote:
> From: Mark Tinguely <tinguely@sgi.com>
>
> Commit f5ea1100 cleans up the disk to host conversions for
> node directory entries, but because a variable is reused in
> xfs_node_toosmall() the next node is not correctly found.
> If the original node is small enough (<= 3/8 of the node size),
> this change may incorrectly cause a node collapse when it should
> not. That will cause an assert in xfstest generic/319:
>
> Assertion failed: first <= last && last < BBTOB(bp->b_length),
> file: /root/newest/xfs/fs/xfs/xfs_trans_buf.c, line: 569
>
> Keep the original node header to get the correct forward node.
>
> (When a node is considered for a merge with a sibling, it overwrites the
> sibling pointers of the original incore nodehdr with the sibling's
> pointers. This leads to loop considering the original node as a merge
> candidate with itself in the second pass, and so it incorrectly
> determines a merge should occur.)
>
> upstream commit 997def25e4b9cee3b01609e18a52f926bca8bd2b
Applied to the 3.10 and 3.11 stable queues, thanks.
greg k-h
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-10 23:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 0:09 [PATCH] xfs: fix node forward in xfs_node_toosmall Ben Myers
2013-10-10 23:02 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-09-20 22:05 Mark Tinguely
2013-09-23 0:08 ` Dave Chinner
2013-09-23 13:38 ` Mark Tinguely
2013-09-23 21:34 ` Michael L. Semon
2013-09-23 21:45 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131010230202.GC4301@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bpm@sgi.com \
--cc=stable@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.