From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 14/16] drm/i915: Add watermark tracepoints
Date: Tue, 15 Oct 2013 10:43:31 +0200
Message-ID: <20131015084331.GB4830@phenom.ffwll.local>
References: <1381335490-4906-1-git-send-email-ville.syrjala@linux.intel.com>
	<1381335490-4906-15-git-send-email-ville.syrjala@linux.intel.com>
	<CA+gsUGTVa8MiGUvoup4n11p4=9zZZREekOgAGOB0aqAZyzBgdw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f171.google.com (mail-ea0-f171.google.com
	[209.85.215.171])
	by gabe.freedesktop.org (Postfix) with ESMTP id 7434EE69D9
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 15 Oct 2013 01:43:39 -0700 (PDT)
Received: by mail-ea0-f171.google.com with SMTP id n15so3867010ead.2
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 15 Oct 2013 01:43:38 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CA+gsUGTVa8MiGUvoup4n11p4=9zZZREekOgAGOB0aqAZyzBgdw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Oct 11, 2013 at 04:40:24PM -0300, Paulo Zanoni wrote:
> 2013/10/9  <ville.syrjala@linux.intel.com>:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> >
> > We may want to know what kind of watermarks got computed and programmed
> > into the hardware. Using tracepoints is much leaner than debug prints.
> >
> > Also add trace call for the watermark state we read out of the
> > hardware during init, though I;m not sure there's any way to see that
> > trace as the events aren't available until the module is loaded.
> >
> > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> I never worked with these things before, but on a quick look it all sound=
s sane.
> =

> Acked-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

I'm not sold on tracepoints being the right tool here. DRM_DEBUG_KMS
probably isn't it, since that would needlessly spam dmesg since it's way
too coarse. But the kernel has this neat dynamic debug subsystem, which
has the upshot that it's all nicely inline with the other modeset debug
noise in dmesg.

I'll punt on this for now.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch