From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751399Ab3JUQHY (ORCPT ); Mon, 21 Oct 2013 12:07:24 -0400 Received: from mga03.intel.com ([143.182.124.21]:33391 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177Ab3JUQHX (ORCPT ); Mon, 21 Oct 2013 12:07:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,535,1378882800"; d="scan'208";a="310641358" Date: Mon, 21 Oct 2013 19:12:48 +0300 From: Mika Westerberg To: Benson Leung Cc: wsa@the-dreams.de, khali@linux-fr.org, andriy.shevchenko@linux.intel.com, jacmet@sunsite.dk, linux-i2c@vger.kernel.org, "linux-kernel@vger.kernel.org" , Duncan Laurie Subject: Re: [PATCH 2/2] i2c-designware-pci: Index Haswell ULT bus names from 0 Message-ID: <20131021161248.GH3521@intel.com> References: <1382326010-4554-1-git-send-email-bleung@chromium.org> <1382326010-4554-3-git-send-email-bleung@chromium.org> <20131021065804.GX3521@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 21, 2013 at 07:20:33AM -0700, Benson Leung wrote: > On Sun, Oct 20, 2013 at 11:58 PM, Mika Westerberg > wrote: > > Is there any real value in having names like "i2c-designware-pci-0" > > available? I would just drop the whole naming dance instead... > > I'd like some way of distinguishing between the two busses by name. It > seems sensible to name them 0 and 1 since that's how they are referred > to on schematics. > > In the chromeos_laptop driver, I do by-name matching of i2c busses to > find busses and instantiate devices, so there is value to have each > named something predictable. OK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH 2/2] i2c-designware-pci: Index Haswell ULT bus names from 0 Date: Mon, 21 Oct 2013 19:12:48 +0300 Message-ID: <20131021161248.GH3521@intel.com> References: <1382326010-4554-1-git-send-email-bleung@chromium.org> <1382326010-4554-3-git-send-email-bleung@chromium.org> <20131021065804.GX3521@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Benson Leung Cc: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Duncan Laurie List-Id: linux-i2c@vger.kernel.org On Mon, Oct 21, 2013 at 07:20:33AM -0700, Benson Leung wrote: > On Sun, Oct 20, 2013 at 11:58 PM, Mika Westerberg > wrote: > > Is there any real value in having names like "i2c-designware-pci-0" > > available? I would just drop the whole naming dance instead... > > I'd like some way of distinguishing between the two busses by name. It > seems sensible to name them 0 and 1 since that's how they are referred > to on schematics. > > In the chromeos_laptop driver, I do by-name matching of i2c busses to > find busses and instantiate devices, so there is value to have each > named something predictable. OK