From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752174Ab3JYIaY (ORCPT ); Fri, 25 Oct 2013 04:30:24 -0400 Received: from cassiel.sirena.org.uk ([80.68.93.111]:36113 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464Ab3JYIaU (ORCPT ); Fri, 25 Oct 2013 04:30:20 -0400 Date: Fri, 25 Oct 2013 09:29:44 +0100 From: Mark Brown To: Hyunhee Kim Cc: dmitry.torokhov@gmail.com, peter.ujfalusi@ti.com, wfp5p@virginia.edu, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, kyungmin.park@samsung.com Message-ID: <20131025082944.GK18506@sirena.org.uk> References: <000101cec628$aaff69a0$00fe3ce0$%kim@samsung.com> <20131024133836.GG18506@sirena.org.uk> <002601ced14b$9c412330$d4c36990$%kim@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BFVE2HhgxTpCzM8t" Content-Disposition: inline In-Reply-To: <002601ced14b$9c412330$d4c36990$%kim@samsung.com> X-Cookie: You have a truly strong individuality. User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 149.254.181.129 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v4] Input: add regulator haptic driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on cassiel.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --BFVE2HhgxTpCzM8t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 25, 2013 at 03:29:51PM +0900, Hyunhee Kim wrote: > From: Hyunhee Kim > Date: Wed, 9 Oct 2013 16:21:36 +0900 > Subject: [PATCH] Input: add regulator haptic driver This is OK from a regulator point of view though there's still a lot of use of regulator devm_ and input devm_ that could happen - it wasn't just the kzalloc(), it was most of the allocations in the driver. You also have some word wrapping in your e-mail so the patch probably won't apply. --BFVE2HhgxTpCzM8t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSaiv0AAoJELSic+t+oim9j3AP/irkpPAqOH6Mf1xklvWGl6/p 2aEY1MS4g6syu0UPkNMTcGdgr/ex5qjjgM56+eJb9blgcJdRLcnWLD1uCVd5ePX4 Dfg8+R/M2higJpNK6LagEqfigXGHHNysWoi9eLNW1aoZArZ4JAJGTjVHgxzHxZ2h w19dsvDDmGPD/OcVDNwM5jCbeVIjtOAQC5LmrqvRi31Z1uTmgObH0E/Z9y0AYB9y jG2oLVCRzFqss7nbGrJ7ttRjMJtsdLsOaxvXuXTJhhoGU6eA3sEbxHOB429VjPi3 kEl2nhG5bg9n9dAEHKaiL1vLnVt8wKv8vBwSK2NKeIwp10fVBWrCjPuI5NToMDnP 9KzleikCkEcgyDnR6HuerOFrLMIXasDm1coE9twlNN1HuVvjvKBZ1MAmP9BjcQnf 0WMspTqzpVppURcE4/yhcAiNDufSfhbD316ugJ5DP7YaRsfNoQOY82rlqAv8ByNG zQNMcXsTqIPKdUmvgosLqbZbmwrJz871HD0aE9ZflnKZ8MeCwaf7QwMLsbYmlgg2 V6pEevkfadlZr3/uQEf8xUsHbJtj30naLYnClcQUq5eEr5OoUYE1aRSEoUCdDE9e a5iJjHYtbQNzEzYoAwrAE23IRZLVAcd3ii30dLfSCFGIOkgJJgb3YbOQpLvPAqBg 5dk9CXq+59F8qO3B+767 =uhLj -----END PGP SIGNATURE----- --BFVE2HhgxTpCzM8t--