From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754298Ab3J2KWJ (ORCPT ); Tue, 29 Oct 2013 06:22:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53720 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339Ab3J2KWI (ORCPT ); Tue, 29 Oct 2013 06:22:08 -0400 Date: Tue, 29 Oct 2013 11:21:38 +0100 From: Jiri Olsa To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Corey Ashford , David Ahern , Ingo Molnar , Namhyung Kim , Paul Mackerras , Peter Zijlstra , Arnaldo Carvalho de Melo , Andi Kleen , Adrian Hunter Subject: Re: [PATCH 0/4] perf tools: Fix -g option handling Message-ID: <20131029102137.GC1093@krava.brq.redhat.com> References: <20131026120336.GA24439@gmail.com> <1382797536-32303-1-git-send-email-jolsa@redhat.com> <20131026143231.GB1069@krava.brq.redhat.com> <20131027065605.GA28433@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131027065605.GA28433@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 27, 2013 at 07:56:05AM +0100, Ingo Molnar wrote: > > * Jiri Olsa wrote: > > > On Sat, Oct 26, 2013 at 04:25:32PM +0200, Jiri Olsa wrote: > > > hi, > > > changing the '-g/-G' options for record/top commands > > > to take NO argument and enable unwind method based > > > on .perfconfig setup (using FP by default). > > > > > > The current -g option parsing moves into the > > > '--call-graph' option. > > > > forgot to mention branch: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git > > perf/cc > > I tested it - works perfectly now for me: > > Acked-and-tested-by: Ingo Molnar > > You might want to give --call-graph a single letter option name as well, > -g, -G, -c, -C are all taken already, but both -l and -L are still > available - maybe use -L for it? ok, I'll addd the -L I'll send it with fixies for other comments thanks, jirka