From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755228Ab3J2Mnl (ORCPT ); Tue, 29 Oct 2013 08:43:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46935 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754513Ab3J2Mnk (ORCPT ); Tue, 29 Oct 2013 08:43:40 -0400 Date: Tue, 29 Oct 2013 10:43:19 -0200 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Namhyung Kim , linux-kernel@vger.kernel.org, Corey Ashford , David Ahern , Ingo Molnar , Paul Mackerras , Peter Zijlstra , Andi Kleen , Adrian Hunter Subject: Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig Message-ID: <20131029124319.GC6944@infradead.org> References: <20131026120336.GA24439@gmail.com> <1382797536-32303-1-git-send-email-jolsa@redhat.com> <1382797536-32303-4-git-send-email-jolsa@redhat.com> <87bo2995o1.fsf@sejong.aot.lge.com> <20131029101821.GA1093@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131029101821.GA1093@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Oct 29, 2013 at 11:18:21AM +0100, Jiri Olsa escreveu: > On Mon, Oct 28, 2013 at 05:10:54PM +0900, Namhyung Kim wrote: > > > + opts->call_graph_enabled = !unset; > > > + > > > > Why not just using symbol_conf.use_callchain? > > > > right, this way we'd be in sync with top Cool, so a patch on top of what is in perf/urgent would be handy, I'll deal with clashes with what is in perf/core, talking about that I think I should do a merge sooner... - ARnaldo