From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753037Ab3KASl6 (ORCPT ); Fri, 1 Nov 2013 14:41:58 -0400 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:58428 "EHLO e06smtp12.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752002Ab3KASl4 (ORCPT ); Fri, 1 Nov 2013 14:41:56 -0400 Date: Fri, 1 Nov 2013 19:40:36 +0100 From: Heiko Carstens To: Greg Kroah-Hartman Cc: Tejun Heo , Kay Sievers , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH driver-core-next] sysfs: use generic_file_llseek() for sysfs_file_operations Message-ID: <20131101184036.GA3597@osiris> References: <20131031114358.GA5551@osiris> <20131031172506.GE11698@mtj.dyndns.org> <20131101141348.GA5411@osiris> <20131101143542.GC20005@htj.dyndns.org> <20131101150448.GB18600@kroah.com> <20131101150800.GE20005@htj.dyndns.org> <20131101161443.GA4593@kroah.com> <20131101171653.GA3669@htj.dyndns.org> <20131101171913.GA2241@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131101171913.GA2241@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13110118-8372-0000-0000-000007A48EA0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 01, 2013 at 10:19:13AM -0700, Greg Kroah-Hartman wrote: > On Fri, Nov 01, 2013 at 01:16:53PM -0400, Tejun Heo wrote: > > Hey, Greg. > > > > Here's proper patch with description and SOB. I'll be traveling from > > tomorrow so I might not be responsive for some days. Can you please > > apply it once Heiko confirms it fixes the issue? > > Will do. > > Heiko, let me know if this fixes your problem or not, thanks. Yes it does fix the problem. strace output looks like before: [pid 2495] open("/sys/class/net/eth0/broadcast", O_RDONLY) = 5 [pid 2495] lseek(5, 0, SEEK_END) = 4096 [pid 2495] lseek(5, 0, SEEK_SET) = 0 [pid 2495] read(5, "ff:ff:ff:ff:ff:ff\n", 4096) = 18 [pid 2495] close(5) = 0 Tested-by: Heiko Carstens