* [PATCH] nfs: fix pnfs Kconfig defaults
@ 2013-11-02 10:22 Christoph Hellwig
2013-11-11 20:30 ` Myklebust, Trond
2013-11-13 16:50 ` [PATCH v2] " Christoph Hellwig
0 siblings, 2 replies; 6+ messages in thread
From: Christoph Hellwig @ 2013-11-02 10:22 UTC (permalink / raw)
To: Trond Myklebust; +Cc: linux-nfs
Defaulting to m seem to prevent building the pnfs layout modules into the
kernel. Default to the value of CONFIG_NFS_FS make sure they are
built in for a built-in NFS and modular for a modular NFS.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/nfs/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
index b5e80b0..f731180 100644
--- a/fs/nfs/Kconfig
+++ b/fs/nfs/Kconfig
@@ -116,17 +116,17 @@ config NFS_V4_2
config PNFS_FILE_LAYOUT
tristate
depends on NFS_V4_1
- default m
+ default NFS_FS
config PNFS_BLOCK
tristate
depends on NFS_V4_1 && BLK_DEV_DM
- default m
+ default NFS_FS
config PNFS_OBJLAYOUT
tristate
depends on NFS_V4_1 && SCSI_OSD_ULD
- default m
+ default NFS_FS
config NFS_V4_1_IMPLEMENTATION_ID_DOMAIN
string "NFSv4.1 Implementation ID Domain"
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] nfs: fix pnfs Kconfig defaults
2013-11-02 10:22 [PATCH] nfs: fix pnfs Kconfig defaults Christoph Hellwig
@ 2013-11-11 20:30 ` Myklebust, Trond
2013-11-11 21:01 ` Christoph Hellwig
2013-11-13 16:50 ` [PATCH v2] " Christoph Hellwig
1 sibling, 1 reply; 6+ messages in thread
From: Myklebust, Trond @ 2013-11-11 20:30 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Linux NFS Mailing List
On Nov 2, 2013, at 6:22, Christoph Hellwig <hch@infradead.org> wrote:
> Defaulting to m seem to prevent building the pnfs layout modules into the
> kernel. Default to the value of CONFIG_NFS_FS make sure they are
> built in for a built-in NFS and modular for a modular NFS.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/nfs/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
> index b5e80b0..f731180 100644
> --- a/fs/nfs/Kconfig
> +++ b/fs/nfs/Kconfig
> @@ -116,17 +116,17 @@ config NFS_V4_2
> config PNFS_FILE_LAYOUT
> tristate
> depends on NFS_V4_1
> - default m
> + default NFS_FS
Shouldn’t that really be
default NFS_V4
in order to get the dependency right? The current Kconfig does allow you to have nfs built in, while leaving NFSv4 as a module.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nfs: fix pnfs Kconfig defaults
2013-11-11 20:30 ` Myklebust, Trond
@ 2013-11-11 21:01 ` Christoph Hellwig
2013-11-11 21:04 ` Myklebust, Trond
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2013-11-11 21:01 UTC (permalink / raw)
To: Myklebust, Trond; +Cc: Christoph Hellwig, Linux NFS Mailing List
On Mon, Nov 11, 2013 at 08:30:48PM +0000, Myklebust, Trond wrote:
> > diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
> > index b5e80b0..f731180 100644
> > --- a/fs/nfs/Kconfig
> > +++ b/fs/nfs/Kconfig
> > @@ -116,17 +116,17 @@ config NFS_V4_2
> > config PNFS_FILE_LAYOUT
> > tristate
> > depends on NFS_V4_1
> > - default m
> > + default NFS_FS
>
> Shouldn?t that really be
> default NFS_V4
> in order to get the dependency right? The current Kconfig does allow you to have nfs built in, while leaving NFSv4 as a module.
Probably should. For some reason I had NFS_V4_1 in mind as a bool.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nfs: fix pnfs Kconfig defaults
2013-11-11 21:01 ` Christoph Hellwig
@ 2013-11-11 21:04 ` Myklebust, Trond
2013-11-11 21:10 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Myklebust, Trond @ 2013-11-11 21:04 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Linux NFS Mailing List
On Mon, 2013-11-11 at 13:01 -0800, Christoph Hellwig wrote:
> On Mon, Nov 11, 2013 at 08:30:48PM +0000, Myklebust, Trond wrote:
> > > diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
> > > index b5e80b0..f731180 100644
> > > --- a/fs/nfs/Kconfig
> > > +++ b/fs/nfs/Kconfig
> > > @@ -116,17 +116,17 @@ config NFS_V4_2
> > > config PNFS_FILE_LAYOUT
> > > tristate
> > > depends on NFS_V4_1
> > > - default m
> > > + default NFS_FS
> >
> > Shouldn?t that really be
> > default NFS_V4
> > in order to get the dependency right? The current Kconfig does allow you to have nfs built in, while leaving NFSv4 as a module.
>
> Probably should. For some reason I had NFS_V4_1 in mind as a bool.
NFS_V4_1 is indeed a bool, but it just defines whether or not we compile
v4.1 behaviour into the 'nfsv4 module' (which is controlled by the
tristate NFS_V4).
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nfs: fix pnfs Kconfig defaults
2013-11-11 21:04 ` Myklebust, Trond
@ 2013-11-11 21:10 ` Christoph Hellwig
0 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2013-11-11 21:10 UTC (permalink / raw)
To: Myklebust, Trond; +Cc: Linux NFS Mailing List
On Mon, Nov 11, 2013 at 09:04:54PM +0000, Myklebust, Trond wrote:
> > Probably should. For some reason I had NFS_V4_1 in mind as a bool.
>
> NFS_V4_1 is indeed a bool, but it just defines whether or not we compile
> v4.1 behaviour into the 'nfsv4 module' (which is controlled by the
> tristate NFS_V4).
Oh right, nfsv4 is a module, but 4.1 is just a flavor inside it. I'll
resend it after testing that it will actually work is intended.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] nfs: fix pnfs Kconfig defaults
2013-11-02 10:22 [PATCH] nfs: fix pnfs Kconfig defaults Christoph Hellwig
2013-11-11 20:30 ` Myklebust, Trond
@ 2013-11-13 16:50 ` Christoph Hellwig
1 sibling, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2013-11-13 16:50 UTC (permalink / raw)
To: Trond Myklebust; +Cc: linux-nfs
Defaulting to m seem to prevent building the pnfs layout modules into the
kernel. Default to the value of CONFIG_NFS_V4 make sure they are
built in for built-in NFSv4 support and modular for a modular NFSv4.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/nfs/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: linux/fs/nfs/Kconfig
===================================================================
--- linux.orig/fs/nfs/Kconfig 2013-11-12 18:42:14.952113008 +0100
+++ linux/fs/nfs/Kconfig 2013-11-13 17:35:24.984154196 +0100
@@ -116,17 +116,17 @@ config NFS_V4_2
config PNFS_FILE_LAYOUT
tristate
depends on NFS_V4_1
- default m
+ default NFS_V4
config PNFS_BLOCK
tristate
depends on NFS_V4_1 && BLK_DEV_DM
- default m
+ default NFS_V4
config PNFS_OBJLAYOUT
tristate
depends on NFS_V4_1 && SCSI_OSD_ULD
- default m
+ default NFS_V4
config NFS_V4_1_IMPLEMENTATION_ID_DOMAIN
string "NFSv4.1 Implementation ID Domain"
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-13 16:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-02 10:22 [PATCH] nfs: fix pnfs Kconfig defaults Christoph Hellwig
2013-11-11 20:30 ` Myklebust, Trond
2013-11-11 21:01 ` Christoph Hellwig
2013-11-11 21:04 ` Myklebust, Trond
2013-11-11 21:10 ` Christoph Hellwig
2013-11-13 16:50 ` [PATCH v2] " Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.