From: Christoph Hellwig <hch@infradead.org>
To: Kyle McMartin <kyle@redhat.com>
Cc: sandeen@redhat.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfsdump: don't assume getdents exists
Date: Wed, 6 Nov 2013 22:58:35 -0800 [thread overview]
Message-ID: <20131107065835.GA24345@infradead.org> (raw)
In-Reply-To: <20131106213635.GC24712@redacted.bos.redhat.com>
On Wed, Nov 06, 2013 at 04:36:35PM -0500, Kyle McMartin wrote:
> New Linux ports are using a standard syscall list that does not include
> deprecated syscalls where 64-bit clean alternatives exist. As a result,
> on arm64, __NR_getdents is undefined, resulting in xfsdump failing to
> build.
>
> To avoid that, in the case where __NR_getdents is unset in unistd.h,
> avoid building the fallback path entirely, since
> __ASSUME_GETDENTS64_SYSCALL will be true, the SYS_getdents64 case will
> be the primary (and only) path used.
Seems like we could drop this mess of a file entirely and just rely
on getdents64 from glibc. The raison d'etre of that file appears to
support 64 bit getdents before glibc really supported it, and I don't
think we'll have to support such old configurations anymore. I'll give
it a quick spin and see how that works out.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-07 6:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 21:36 [PATCH] xfsdump: don't assume getdents exists Kyle McMartin
2013-11-06 22:48 ` Dave Chinner
2013-11-06 22:56 ` Kyle McMartin
2013-11-06 23:17 ` Dave Chinner
2013-11-06 23:19 ` Kyle McMartin
2013-11-07 6:58 ` Christoph Hellwig [this message]
2013-11-07 7:06 ` Christoph Hellwig
2013-12-10 14:46 ` Eric Sandeen
2013-12-10 19:50 ` Kyle McMartin
2014-03-22 5:12 ` Kyle McMartin
2014-03-22 8:53 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107065835.GA24345@infradead.org \
--to=hch@infradead.org \
--cc=kyle@redhat.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.