From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: jfrederich@gmail.com, dsd@laptop.org, jon.nettleton@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH 2/2] staging/olpc_docn: reorder the lock sequence to avoid potential dead lock
Date: Thu, 7 Nov 2013 14:38:49 +0300 [thread overview]
Message-ID: <20131107113849.GM20521@mwanda> (raw)
In-Reply-To: <527999DC.1090206@cn.fujitsu.com>
On Wed, Nov 06, 2013 at 09:22:36AM +0800, Gu Zheng wrote:
> Hi Dan,
> On 11/05/2013 07:02 PM, Dan Carpenter wrote:
>
> > On Tue, Nov 05, 2013 at 06:01:00PM +0800, Gu Zheng wrote:
> >> The lock sequence of dcon_blank_fb(fb_info->lock ---> console_lock) is against
> >> with the one of console_callback(console_lock ---> fb_info->lock), it'll
> >> lead to a potential dead lock, so reorder the lock sequence of dcon_blank_fb
> >> to avoid the potential dead lock.
> >>
> >> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
> >
> > Relax, Greg isn't taking new patches for another three weeks because the
> > merge window is open.
>
> Got it, I just want to gain some comments about this patch.
>
If no one complains that means it is approved. :)
regards,
dan carpenter
prev parent reply other threads:[~2013-11-07 11:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 10:01 [RESEND PATCH 2/2] staging/olpc_docn: reorder the lock sequence to avoid potential dead lock Gu Zheng
2013-11-05 11:02 ` Dan Carpenter
2013-11-06 1:22 ` Gu Zheng
2013-11-07 11:38 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107113849.GM20521@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dsd@laptop.org \
--cc=gregkh@linuxfoundation.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=jfrederich@gmail.com \
--cc=jon.nettleton@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.