From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753315Ab3KLIY5 (ORCPT ); Tue, 12 Nov 2013 03:24:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37794 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751931Ab3KLIYs (ORCPT ); Tue, 12 Nov 2013 03:24:48 -0500 Date: Tue, 12 Nov 2013 16:24:01 +0800 From: Dave Young To: Greg KH Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, bp@alien8.de Subject: Re: [patch 4/7 v2] export more efi table variable to sysfs Message-ID: <20131112082401.GA13899@dhcp-16-126.nay.redhat.com> References: <20131105082007.872550445@dhcp-16-126.nay.redhat.com> <20131105082717.561020034@dhcp-16-126.nay.redhat.com> <20131112004014.GA15377@kroah.com> <20131112081937.GE6999@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131112081937.GE6999@dhcp-16-126.nay.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/12/13 at 04:19pm, Dave Young wrote: > On 11/11/13 at 04:40pm, Greg KH wrote: > > On Tue, Nov 05, 2013 at 04:20:11PM +0800, dyoung@redhat.com wrote: > > > Export fw_vendor, runtime and config tables physical > > > addresses to /sys/firmware/efi/systab becaue kexec > > > kernel will need them. > > > > sysfs files are one-value-per-file. > > > > Please don't abuse this and add more values to this single file, in > > fact, it should be broken up into individual sysfs files as it is, > > because this isn't ok now. > > > > Sorry, you don't get to abuse this anymore :( > > Ok, I know this, just creating this without thinking about carefully. > Will redo the patch, thanks for catching. I would like to add new files for the values used in this patchset. And will split the original systab later in another patchset. > > Thanks > Dave From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Young Subject: Re: [patch 4/7 v2] export more efi table variable to sysfs Date: Tue, 12 Nov 2013 16:24:01 +0800 Message-ID: <20131112082401.GA13899@dhcp-16-126.nay.redhat.com> References: <20131105082007.872550445@dhcp-16-126.nay.redhat.com> <20131105082717.561020034@dhcp-16-126.nay.redhat.com> <20131112004014.GA15377@kroah.com> <20131112081937.GE6999@dhcp-16-126.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20131112081937.GE6999-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Greg KH Cc: mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: linux-efi@vger.kernel.org On 11/12/13 at 04:19pm, Dave Young wrote: > On 11/11/13 at 04:40pm, Greg KH wrote: > > On Tue, Nov 05, 2013 at 04:20:11PM +0800, dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org wrote: > > > Export fw_vendor, runtime and config tables physical > > > addresses to /sys/firmware/efi/systab becaue kexec > > > kernel will need them. > > > > sysfs files are one-value-per-file. > > > > Please don't abuse this and add more values to this single file, in > > fact, it should be broken up into individual sysfs files as it is, > > because this isn't ok now. > > > > Sorry, you don't get to abuse this anymore :( > > Ok, I know this, just creating this without thinking about carefully. > Will redo the patch, thanks for catching. I would like to add new files for the values used in this patchset. And will split the original systab later in another patchset. > > Thanks > Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vg9HB-0007Fb-7y for kexec@lists.infradead.org; Tue, 12 Nov 2013 08:24:45 +0000 Date: Tue, 12 Nov 2013 16:24:01 +0800 From: Dave Young Subject: Re: [patch 4/7 v2] export more efi table variable to sysfs Message-ID: <20131112082401.GA13899@dhcp-16-126.nay.redhat.com> References: <20131105082007.872550445@dhcp-16-126.nay.redhat.com> <20131105082717.561020034@dhcp-16-126.nay.redhat.com> <20131112004014.GA15377@kroah.com> <20131112081937.GE6999@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131112081937.GE6999@dhcp-16-126.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Greg KH Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com, vgoyal@redhat.com On 11/12/13 at 04:19pm, Dave Young wrote: > On 11/11/13 at 04:40pm, Greg KH wrote: > > On Tue, Nov 05, 2013 at 04:20:11PM +0800, dyoung@redhat.com wrote: > > > Export fw_vendor, runtime and config tables physical > > > addresses to /sys/firmware/efi/systab becaue kexec > > > kernel will need them. > > > > sysfs files are one-value-per-file. > > > > Please don't abuse this and add more values to this single file, in > > fact, it should be broken up into individual sysfs files as it is, > > because this isn't ok now. > > > > Sorry, you don't get to abuse this anymore :( > > Ok, I know this, just creating this without thinking about carefully. > Will redo the patch, thanks for catching. I would like to add new files for the values used in this patchset. And will split the original systab later in another patchset. > > Thanks > Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec