All of lore.kernel.org
 help / color / mirror / Atom feed
From: chrubis@suse.cz
To: Siva Padhy <siva.padhy@lge.com>
Cc: "ltp-list@lists.sourceforge.net" <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH V2] BindMounts: fix to properly unmount during cleanup
Date: Wed, 13 Nov 2013 17:39:28 +0100	[thread overview]
Message-ID: <20131113163928.GA12406@rei.Home> (raw)
In-Reply-To: <81212EE27BC298499DBD7CA069AAD07142E38D167A@LGEVEXMBAPSVC2.LGE.NET>

Hi!
> The fs_bind testcases creates the mount directories for testing.
> When the testcase exits, those directories were not properly unmounted.
> The reason of the issues are:
> 
>  1. Some directories were kept mounted, even after the cleanup() routine, as the unmount code is missing.
>  2. Some "umount" command execution fails, as they are dependent on some other mounted directories.
> 
> Error Report
> ------------
> rbind/test02    1  TPASS  :  rbind/test02: PASSED
> /kvt.new/ltp/testscripts/test_fs_bind.sh    0  TWARN  :  rbind/test02 did not properly clean up "/tmp/ltp-XXXX9qdYqG/sandbox"
> 
> rbind/test38    1  TPASS  :  rbind/test38: PASSED
> /kvt.new/ltp/testscripts/test_fs_bind.sh    0  TWARN  :  rbind/test38 did not properly clean up "/tmp/ltp-XXXX9qdYqG/sandbox"
> 
> This patch add/reorder the unmount code to fix the above TWARN messages.
> 
> Modified-by: Jan Stancek <jstancek@redhat.com>
> Signed-off-by: Siva  <siva.padhy@lge.com>

Pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

      parent reply	other threads:[~2013-11-13 16:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11  1:51 [LTP] [PATCH V2] BindMounts: fix to properly unmount during cleanup Siva Padhy
2013-11-11  9:22 ` Jan Stancek
2013-11-13 16:39 ` chrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131113163928.GA12406@rei.Home \
    --to=chrubis@suse.cz \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=siva.padhy@lge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.