From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Date: Wed, 13 Nov 2013 17:33:18 +0000 Subject: Re: [patch] bus: mvebu-mbus: potential forever loop in mvebu_mbus_init() Message-Id: <20131113173317.GB2466@localhost> List-Id: References: <20131113075024.GH25541@elgon.mountain> In-Reply-To: <20131113075024.GH25541@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: kernel-janitors@vger.kernel.org On Wed, Nov 13, 2013 at 10:18:30AM -0500, Jason Cooper wrote: > Dan, >=20 > On Wed, Nov 13, 2013 at 10:50:24AM +0300, Dan Carpenter wrote: > > "of_id->compatible" is an array and not a pointer so it can never be > > NULL. >=20 > Thanks for pointing this out. >=20 > > Signed-off-by: Dan Carpenter > > --- > > I'm not able to compile this. > >=20 > > diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c > > index 2394e97..c646a76 100644 > > --- a/drivers/bus/mvebu-mbus.c > > +++ b/drivers/bus/mvebu-mbus.c > > @@ -734,11 +734,11 @@ int __init mvebu_mbus_init(const char *soc, phys_= addr_t mbuswins_phys_base, > > { > > const struct of_device_id *of_id; > > =20 > > - for (of_id =3D of_mvebu_mbus_ids; of_id->compatible; of_id++) > > + for (of_id =3D of_mvebu_mbus_ids; of_id->compatible[0]; of_id++) > > if (!strcmp(of_id->compatible, soc)) > > break; >=20 > Ezequiel et al, >=20 > The comment above the declaration for of_mvebu_mbus_ids says: >=20 > /* > * The driver doesn't yet have a DT binding because the details of > * this DT binding still need to be sorted out. However, as a > * preparation, we already use of_device_id to match a SoC description > * string against the SoC specific details of this driver. > */ >=20 > I believe we have a binding now. ;-) Care to look this over and > provide a more complete cleanup patch? >=20 Sure. --=20 Ezequiel Garc=C3=ADa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html