From: Peter Zijlstra <peterz@infradead.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Tejun Heo <tj@kernel.org>, David Rientjes <rientjes@google.com>,
David Laight <David.Laight@ACULAB.COM>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Ingo Molnar <mingo@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: oom-kill && frozen()
Date: Wed, 13 Nov 2013 18:42:20 +0100 [thread overview]
Message-ID: <20131113174220.GQ21461@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20131113170724.GA17739@redhat.com>
On Wed, Nov 13, 2013 at 06:07:24PM +0100, Oleg Nesterov wrote:
> 4. Finally, change try_to_wake_up() path to do
>
> - p->state = TASK_WAKING;
> + p->state &= ~state;
> + if (p->state & ~(TASK_DEAD | TASK_WAKEKILL | TASK_PARKED))
> + return;
> + else
> + p->state = TASK_WAKING;
>
> IOW, if the task sleeps in, say, TASK_INTERRUPTIBLE | __TASK_FROZEN
> then it need both try_to_wake_up(TASK_INTERRUPTIBLE) and
> try_to_wake_up(__TASK_FROZEN) to wake up.
> Tejun, Peter, do you think this makes any sense? I am just curious, but
> "selective wakeup" looks potentially useful.
I've never looked at any of this freeze stuff, so I cannot comment too
much. However we should be very careful not to add too much to relative
hot paths for the relative rare case of freezing stuff.
next prev parent reply other threads:[~2013-11-13 17:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 13:53 [PATCH] ipvs: Remove unused variable ret from sync_thread_master() Geert Uytterhoeven
2013-11-12 14:13 ` Peter Zijlstra
2013-11-12 14:21 ` David Laight
2013-11-12 14:31 ` Peter Zijlstra
2013-11-12 14:38 ` David Laight
2013-11-12 16:26 ` Oleg Nesterov
2013-11-12 14:52 ` Peter Zijlstra
2013-11-12 16:21 ` Oleg Nesterov
2013-11-12 16:56 ` oom-kill && frozen() Oleg Nesterov
2013-11-13 3:20 ` Tejun Heo
2013-11-13 17:07 ` Oleg Nesterov
2013-11-13 17:42 ` Peter Zijlstra [this message]
2013-11-13 18:15 ` Oleg Nesterov
2013-11-13 19:11 ` __refrigerator() && saved task->state Oleg Nesterov
2013-11-13 19:14 ` Peter Zijlstra
2013-11-13 19:40 ` Oleg Nesterov
2013-11-12 17:00 ` [PATCH] ipvs: Remove unused variable ret from sync_thread_master() Peter Zijlstra
2013-11-12 18:04 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131113174220.GQ21461@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=David.Laight@ACULAB.COM \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.