From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752618Ab3KNBlF (ORCPT ); Wed, 13 Nov 2013 20:41:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30445 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752530Ab3KNBkv (ORCPT ); Wed, 13 Nov 2013 20:40:51 -0500 Date: Thu, 14 Nov 2013 09:39:55 +0800 From: Dave Young To: Matt Fleming Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, bp@alien8.de Subject: Re: [patch 3/7 v2] Cleanup efi_enter_virtual_mode function Message-ID: <20131114013955.GC4081@dhcp-16-126.nay.redhat.com> References: <20131105082007.872550445@dhcp-16-126.nay.redhat.com> <20131105082716.825753041@dhcp-16-126.nay.redhat.com> <20131113155017.GB17248@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131113155017.GB17248@console-pimps.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/13/13 at 03:50pm, Matt Fleming wrote: > On Tue, 05 Nov, at 04:20:10PM, dyoung@redhat.com wrote: > > Add two small functions: > > efi_merge_regions and efi_map_regions, efi_enter_virtual_mode > > calls them instead of embedding two long for loop. > > > > v1->v2: > > refresh; coding style fixes. > > > > Signed-off-by: Dave Young > > --- > > arch/x86/platform/efi/efi.c | 107 +++++++++++++++++++++++++------------------- > > 1 file changed, 63 insertions(+), 44 deletions(-) > > [...] > > > @@ -860,17 +840,59 @@ void __init efi_enter_virtual_mode(void) > > efi.systab = (efi_system_table_t *) (unsigned long) systab; > > } > > > > - new_memmap = krealloc(new_memmap, > > - (count + 1) * memmap.desc_size, > > - GFP_KERNEL); > > - if (!new_memmap) > > + *new_memmap = krealloc(*new_memmap, > > + (*count + 1) * memmap.desc_size, > > + GFP_KERNEL); > > + if (!*new_memmap) > > goto err_out; > > > > - memcpy(new_memmap + (count * memmap.desc_size), md, > > + memcpy(*new_memmap + (*count * memmap.desc_size), md, > > memmap.desc_size); > > - count++; > > + (*count)++; > > } > > > > +err_out: > > + pr_err("Error reallocating memory, EFI runtime non-functional!\n"); > > +} > > You should really return an error value here so that we don't > dereference 'new_memmap' below if it's NULL. In fact, just return the > memmap... Good catch, will do > > > + > > + efi_merge_regions(); > > + > > + efi_map_regions(&new_memmap, &count); > > + > > and make sure to check the return value here. Ok. > -- > Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Young Subject: Re: [patch 3/7 v2] Cleanup efi_enter_virtual_mode function Date: Thu, 14 Nov 2013 09:39:55 +0800 Message-ID: <20131114013955.GC4081@dhcp-16-126.nay.redhat.com> References: <20131105082007.872550445@dhcp-16-126.nay.redhat.com> <20131105082716.825753041@dhcp-16-126.nay.redhat.com> <20131113155017.GB17248@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20131113155017.GB17248-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Matt Fleming Cc: mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: linux-efi@vger.kernel.org On 11/13/13 at 03:50pm, Matt Fleming wrote: > On Tue, 05 Nov, at 04:20:10PM, dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org wrote: > > Add two small functions: > > efi_merge_regions and efi_map_regions, efi_enter_virtual_mode > > calls them instead of embedding two long for loop. > > > > v1->v2: > > refresh; coding style fixes. > > > > Signed-off-by: Dave Young > > --- > > arch/x86/platform/efi/efi.c | 107 +++++++++++++++++++++++++------------------- > > 1 file changed, 63 insertions(+), 44 deletions(-) > > [...] > > > @@ -860,17 +840,59 @@ void __init efi_enter_virtual_mode(void) > > efi.systab = (efi_system_table_t *) (unsigned long) systab; > > } > > > > - new_memmap = krealloc(new_memmap, > > - (count + 1) * memmap.desc_size, > > - GFP_KERNEL); > > - if (!new_memmap) > > + *new_memmap = krealloc(*new_memmap, > > + (*count + 1) * memmap.desc_size, > > + GFP_KERNEL); > > + if (!*new_memmap) > > goto err_out; > > > > - memcpy(new_memmap + (count * memmap.desc_size), md, > > + memcpy(*new_memmap + (*count * memmap.desc_size), md, > > memmap.desc_size); > > - count++; > > + (*count)++; > > } > > > > +err_out: > > + pr_err("Error reallocating memory, EFI runtime non-functional!\n"); > > +} > > You should really return an error value here so that we don't > dereference 'new_memmap' below if it's NULL. In fact, just return the > memmap... Good catch, will do > > > + > > + efi_merge_regions(); > > + > > + efi_map_regions(&new_memmap, &count); > > + > > and make sure to check the return value here. Ok. > -- > Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VglvK-0002CN-UF for kexec@lists.infradead.org; Thu, 14 Nov 2013 01:40:47 +0000 Date: Thu, 14 Nov 2013 09:39:55 +0800 From: Dave Young Subject: Re: [patch 3/7 v2] Cleanup efi_enter_virtual_mode function Message-ID: <20131114013955.GC4081@dhcp-16-126.nay.redhat.com> References: <20131105082007.872550445@dhcp-16-126.nay.redhat.com> <20131105082716.825753041@dhcp-16-126.nay.redhat.com> <20131113155017.GB17248@console-pimps.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131113155017.GB17248@console-pimps.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Matt Fleming Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com, vgoyal@redhat.com On 11/13/13 at 03:50pm, Matt Fleming wrote: > On Tue, 05 Nov, at 04:20:10PM, dyoung@redhat.com wrote: > > Add two small functions: > > efi_merge_regions and efi_map_regions, efi_enter_virtual_mode > > calls them instead of embedding two long for loop. > > > > v1->v2: > > refresh; coding style fixes. > > > > Signed-off-by: Dave Young > > --- > > arch/x86/platform/efi/efi.c | 107 +++++++++++++++++++++++++------------------- > > 1 file changed, 63 insertions(+), 44 deletions(-) > > [...] > > > @@ -860,17 +840,59 @@ void __init efi_enter_virtual_mode(void) > > efi.systab = (efi_system_table_t *) (unsigned long) systab; > > } > > > > - new_memmap = krealloc(new_memmap, > > - (count + 1) * memmap.desc_size, > > - GFP_KERNEL); > > - if (!new_memmap) > > + *new_memmap = krealloc(*new_memmap, > > + (*count + 1) * memmap.desc_size, > > + GFP_KERNEL); > > + if (!*new_memmap) > > goto err_out; > > > > - memcpy(new_memmap + (count * memmap.desc_size), md, > > + memcpy(*new_memmap + (*count * memmap.desc_size), md, > > memmap.desc_size); > > - count++; > > + (*count)++; > > } > > > > +err_out: > > + pr_err("Error reallocating memory, EFI runtime non-functional!\n"); > > +} > > You should really return an error value here so that we don't > dereference 'new_memmap' below if it's NULL. In fact, just return the > memmap... Good catch, will do > > > + > > + efi_merge_regions(); > > + > > + efi_map_regions(&new_memmap, &count); > > + > > and make sure to check the return value here. Ok. > -- > Matt Fleming, Intel Open Source Technology Center _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec