From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752064Ab3KPEyK (ORCPT ); Fri, 15 Nov 2013 23:54:10 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:38519 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172Ab3KPEyD (ORCPT ); Fri, 15 Nov 2013 23:54:03 -0500 Date: Sat, 16 Nov 2013 13:53:56 +0900 From: Tejun Heo To: Bjorn Helgaas Cc: Hugh Dickins , Steven Rostedt , Li Zefan , Markus Blank-Burian , Michal Hocko , Johannes Weiner , David Rientjes , Ying Han , Greg Thelen , Michel Lespinasse , cgroups@vger.kernel.org, "Srivatsa S. Bhat" , Lai Jiangshan , "linux-kernel@vger.kernel.org" , "Rafael J. Wysocki" , Alexander Duyck , Yinghai Lu , "linux-pci@vger.kernel.org" Subject: Re: Possible regression with cgroups in 3.11 Message-ID: <20131116045356.GA5618@mtj.dyndns.org> References: <525CB337.8050105@huawei.com> <5270BFE7.4000602@huawei.com> <20131031130647.0ff6f2c7@gandalf.local.home> <20131113032804.GB19394@mtj.dyndns.org> <20131113073806.GA23244@mtj.dyndns.org> <20131116002820.GA31073@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131116002820.GA31073@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Bjorn. On Fri, Nov 15, 2013 at 05:28:20PM -0700, Bjorn Helgaas wrote: > It would be better to fix PCI so we don't call VF driver .probe() methods > from inside a PF driver .probe() method, but that's a bigger project. Yeah, if pci doesn't need the recursion, we can simply revert restore the lockdep annoation on work_on_cpu(). > @@ -293,7 +293,9 @@ static int pci_call_probe(struct pci_driver *drv, struct pci_dev *dev, > its local memory on the right node without any need to > change it. */ > node = dev_to_node(&dev->dev); > - if (node >= 0) { > + preempt_disable(); > + > + if (node >= 0 && node != numa_node_id()) { A bit of comment here would be nice but yeah I think this should work. Can you please also queue the revert of c2fda509667b ("workqueue: allow work_on_cpu() to be called recursively") after this patch? Please feel free to add my acked-by. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: Possible regression with cgroups in 3.11 Date: Sat, 16 Nov 2013 13:53:56 +0900 Message-ID: <20131116045356.GA5618@mtj.dyndns.org> References: <525CB337.8050105@huawei.com> <5270BFE7.4000602@huawei.com> <20131031130647.0ff6f2c7@gandalf.local.home> <20131113032804.GB19394@mtj.dyndns.org> <20131113073806.GA23244@mtj.dyndns.org> <20131116002820.GA31073@google.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=eDXKektQcnU99fGYDjFj/5xrZiv7CIzRIcSyALLew18=; b=mIOgNEjQ3zXfvoXL/ZFZyv8PvH2zq4PQVUehGnK8YCQziMTe8VZyn4lRmSuSTdCh2D iRCUvtTJBH7xCjZ7eYdnkqFNYobTpCYzIVD/JU/x4pZ9hut5Z3W8Fk9cn6GaY6YJmgBb QxUxk5Mu7Z2h89rZK1PC1ynZ14AiCFe8eUkINwUEYit6tnRyLeDFJ30uj9YbeUVtYxpO L44zeG98GmqvlrUwT4T1h2Lj+qpGh1GUqhWK+PfolSHzx2a+bAKnGagRqyPul5z/p9rz CVtrDAZVKe4ZRP5Qd1NWTnAcs69foBZqHCkmJUCsHqO60nCYIn27Rvc+ufwArrSTRlal 2U3A== Content-Disposition: inline In-Reply-To: <20131116002820.GA31073-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bjorn Helgaas Cc: Hugh Dickins , Steven Rostedt , Li Zefan , Markus Blank-Burian , Michal Hocko , Johannes Weiner , David Rientjes , Ying Han , Greg Thelen , Michel Lespinasse , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Srivatsa S. Bhat" , Lai Jiangshan , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Rafael J. Wysocki" , Alexander Duyck , Yinghai Lu , "linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" Hello, Bjorn. On Fri, Nov 15, 2013 at 05:28:20PM -0700, Bjorn Helgaas wrote: > It would be better to fix PCI so we don't call VF driver .probe() methods > from inside a PF driver .probe() method, but that's a bigger project. Yeah, if pci doesn't need the recursion, we can simply revert restore the lockdep annoation on work_on_cpu(). > @@ -293,7 +293,9 @@ static int pci_call_probe(struct pci_driver *drv, struct pci_dev *dev, > its local memory on the right node without any need to > change it. */ > node = dev_to_node(&dev->dev); > - if (node >= 0) { > + preempt_disable(); > + > + if (node >= 0 && node != numa_node_id()) { A bit of comment here would be nice but yeah I think this should work. Can you please also queue the revert of c2fda509667b ("workqueue: allow work_on_cpu() to be called recursively") after this patch? Please feel free to add my acked-by. Thanks. -- tejun