From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-input@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 1/2] Input: twl4030-keypad - add device tree support
Date: Sun, 17 Nov 2013 19:58:15 -0800 [thread overview]
Message-ID: <20131118035815.GA3311@core.coreip.homeip.net> (raw)
In-Reply-To: <20131117182840.GA30012@xo-6d-61-c0.localdomain>
On Sun, Nov 17, 2013 at 07:28:40PM +0100, Pavel Machek wrote:
> Hi!
>
> > On Mon, Nov 11, 2013 at 11:19:41PM +0100, Pavel Machek wrote:
> > > > + if (of_get_property(np, "linux,input-no-autorepeat", NULL))
> > > > + keypad_data->no_autorepeat = true;
> > >
> > > From 2/2:
> > >
> > > +Optional Properties specific to linux:
> > > +- linux,keypad-no-autorepeat: do not enable autorepeat feature.
> > >
> > > I'm confused now.
> >
> > good catch! That happens when one tries to mimic other drivers :/
> >
> > I just checked all DT input drivers for autorepeat keyword:
> >
> > DRIVER CODE DOCUMENTATION
> > twl4030-keypad linux,input-no-autorepeat linux,keypad-no-autorepeat
> > omap4-keypad linux,input-no-autorepeat linux,keypad-no-autorepeat
> > samsung-keypad linux,input-no-autorepeat linux,keypad-no-autorepeat
> > stmpe-keypad st,no-autorepeat st,no-autorepeat
> > spear-keyboard autorepeat autorepeat
> > tca8418-keypad keypad,autorepeat --- not documented ---
> > gpio-matrix-keypad linux,no-autorepeat linux,no-autorepeat
> > gpio-keys-polled autorepeat autorepeat
> > gpio-keys autorepeat --- no documentation ---
> >
> > Any suggestions how to continue fixing this mess? I guess first of
> > all the documentation of omap4-keypad, samsung-keypad and of course
> > the new twl4030-keypad driver should be fixed.
> >
> > Next it would be nice to choose one standard property name for this
> > and use it for twl4030-keypad. I suggest to use "linux,input-no-autorepeat".
>
> I'd suggest just simple "autorepeat", so that we get rid of ugly double-negation.
The idea was that majority of setups want autorepeat so in the absence
of the property autorepeat is turned on.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2013-11-18 3:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 22:14 [PATCHv3 0/2] twl4030-keypad DT binding Sebastian Reichel
2013-11-08 22:14 ` [PATCHv3 1/2] Input: twl4030-keypad - add device tree support Sebastian Reichel
2013-11-11 22:19 ` Pavel Machek
2013-11-12 3:25 ` Sebastian Reichel
2013-11-17 18:28 ` Pavel Machek
2013-11-18 3:58 ` Dmitry Torokhov [this message]
2013-11-19 12:50 ` Pavel Machek
2013-11-24 17:17 ` Sebastian Reichel
2013-11-08 22:14 ` [PATCHv3 2/2] dt: binding documentation for twl4030-keypad Sebastian Reichel
2013-11-30 16:53 ` [PATCHv4 0/2] twl4030-keypad DT binding Sebastian Reichel
2013-11-30 16:53 ` [PATCHv4 1/2] Input: twl4030-keypad - add device tree support Sebastian Reichel
2013-11-30 16:53 ` [PATCHv4 2/2] dt: binding documentation for twl4030-keypad Sebastian Reichel
2013-12-13 18:47 ` [PATCHv4 0/2] twl4030-keypad DT binding Sebastian Reichel
2014-01-04 5:40 ` Sebastian Reichel
2014-01-04 8:49 ` Dmitry Torokhov
2014-01-05 3:50 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118035815.GA3311@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.