From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH] ext4: add generic uevent infrastructure Date: Tue, 19 Nov 2013 12:36:21 +1100 Message-ID: <20131119013621.GH11434@dastard> References: <1384785520-607-1-git-send-email-dmonakhov@openvz.org> <20131118162045.GA3268@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Dmitry Monakhov , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Content-Disposition: inline In-Reply-To: <20131118162045.GA3268@infradead.org> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Nov 18, 2013 at 08:20:45AM -0800, Christoph Hellwig wrote: > On Mon, Nov 18, 2013 at 06:38:40PM +0400, Dmitry Monakhov wrote: > > *Purpose: > > It is reasonable to annaunce fs related events via uevent infrastructure. > > This patch implement only ext4'th part, but IMHO this should be usefull for > > any generic filesystem. > > It does indeed look very generic. How about you try to redo it to sit > at the VFS level? I certain agree with that. I'd also like to see ENOSPC notifications as that would obliviate the need for distros like RHEL to ship systemtap scripts to generate such notifications for admins.... > Also Jan Kara has done quota netlink notifications a while ago, which > fit into the same sort of niche. The question I'm asking is whether we really want a new interface for these events? Shouldn't we really try to use an existing filesystem event interface for generating these events (e.g. fanotify) rather than adding yet another disjoint filesystem event interface to the kernel? Cheers, Dave. -- Dave Chinner david@fromorbit.com