From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>,
Dmitry Monakhov <dmonakhov@openvz.org>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] ext4: add generic uevent infrastructure
Date: Tue, 19 Nov 2013 12:17:19 +0100 [thread overview]
Message-ID: <20131119111719.GA25036@quack.suse.cz> (raw)
In-Reply-To: <20131119102501.GA5107@infradead.org>
On Tue 19-11-13 02:25:01, Christoph Hellwig wrote:
> On Tue, Nov 19, 2013 at 12:36:21PM +1100, Dave Chinner wrote:
> > I certain agree with that. I'd also like to see ENOSPC notifications
> > as that would obliviate the need for distros like RHEL to ship
> > systemtap scripts to generate such notifications for admins....
>
> The ENOSPC case would be a natural tag on to Jan's quota notification,
> and I have a vague memory that someone started implementing it or
> at least talked about it.
Yes, quota netlink interface is technically very easy to extend to also
provide ENOSPC notifications. It's just that the name of generic netlink
family is 'VFS_DQUOT' so ENOSPC notifications do not fit very well with
that name but it isn't too bad either.
> > > Also Jan Kara has done quota netlink notifications a while ago, which
> > > fit into the same sort of niche.
> >
> > The question I'm asking is whether we really want a new interface
> > for these events? Shouldn't we really try to use an existing
> > filesystem event interface for generating these events
>
> Good quetion, and the quota netlink notifications would be the natural
> place to tag on at least some of this.
>
> > (e.g.
> > fanotify) rather than adding yet another disjoint filesystem event
> > interface to the kernel?
>
> It needs to be a per-fs interface, and as Dmitry pointed out fanotify
> is a per-file one.
I agree fanotify is really a bad fit.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2013-11-19 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 14:38 [PATCH] ext4: add generic uevent infrastructure Dmitry Monakhov
2013-11-18 16:20 ` Christoph Hellwig
2013-11-19 1:36 ` Dave Chinner
2013-11-19 9:35 ` Dmitry Monakhov
2013-11-19 10:25 ` Christoph Hellwig
2013-11-19 11:17 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119111719.GA25036@quack.suse.cz \
--to=jack@suse.cz \
--cc=david@fromorbit.com \
--cc=dmonakhov@openvz.org \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.