From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vikvl-0004LQ-Gg for qemu-devel@nongnu.org; Tue, 19 Nov 2013 08:01:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vikvf-0004Zu-E1 for qemu-devel@nongnu.org; Tue, 19 Nov 2013 08:01:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vikvf-0004Zl-68 for qemu-devel@nongnu.org; Tue, 19 Nov 2013 08:01:19 -0500 Date: Tue, 19 Nov 2013 12:29:58 +0100 From: Kevin Wolf Message-ID: <20131119112958.GE4040@dhcp-200-207.str.redhat.com> References: <1384121021-24815-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1384121021-24815-4-git-send-email-xiawenc@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1384121021-24815-4-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH V5 3/5] qemu-iotests: add 058 internal snapshot export with qemu-nbd case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: pbonzini@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 10.11.2013 um 23:03 hat Wenchao Xia geschrieben: > Signed-off-by: Wenchao Xia > --- > tests/qemu-iotests/058 | 102 ++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/058.out | 32 ++++++++++++++ > tests/qemu-iotests/check | 1 + > tests/qemu-iotests/group | 1 + > 4 files changed, 136 insertions(+), 0 deletions(-) > create mode 100755 tests/qemu-iotests/058 > create mode 100644 tests/qemu-iotests/058.out I think this should have: _supported_proto nbd Or otherwise the check in common needs to be changed. At least for me the test failed without an error message because I didn't have a qemu-nbd symlink in place. Kevin