From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752292Ab3KSMSU (ORCPT ); Tue, 19 Nov 2013 07:18:20 -0500 Received: from arkanian.console-pimps.org ([212.110.184.194]:55436 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751663Ab3KSMSS (ORCPT ); Tue, 19 Nov 2013 07:18:18 -0500 Date: Tue, 19 Nov 2013 12:18:14 +0000 From: Matt Fleming To: Dave Young Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, bp@alien8.de Subject: Re: [patch 5/7 v2] export efi runtime memory mapping to sysfs Message-ID: <20131119121814.GB11521@console-pimps.org> References: <20131105082007.872550445@dhcp-16-126.nay.redhat.com> <20131105082718.185728964@dhcp-16-126.nay.redhat.com> <20131113155027.GC17248@console-pimps.org> <20131114015047.GD4081@dhcp-16-126.nay.redhat.com> <20131118021641.GC4025@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131118021641.GC4025@dhcp-16-126.nay.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Nov, at 10:16:41AM, Dave Young wrote: > Matt, desc_version is already in boot_params.efi_info, so kexec-tools > can get the version from there. I do not need to export it as another > file. OK, cool. > I think for now we do not need worry much about the compatibility > issue, do you think I need add version checking in kexec-tools > currently? like below? > > if (desc_version != 1) /* current version is 1? */ > error out it is not supported Yes, something like that. If you already have kexec-specific ways of checking a version number then that's fine. Just make sure that, if the EFI memory descriptor structure is extended in the future and more files are exported for each descriptor, kexec-tools say "I don't know how to build a data structure for from these files". -- Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [patch 5/7 v2] export efi runtime memory mapping to sysfs Date: Tue, 19 Nov 2013 12:18:14 +0000 Message-ID: <20131119121814.GB11521@console-pimps.org> References: <20131105082007.872550445@dhcp-16-126.nay.redhat.com> <20131105082718.185728964@dhcp-16-126.nay.redhat.com> <20131113155027.GC17248@console-pimps.org> <20131114015047.GD4081@dhcp-16-126.nay.redhat.com> <20131118021641.GC4025@dhcp-16-126.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20131118021641.GC4025-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dave Young Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org List-Id: linux-efi@vger.kernel.org On Mon, 18 Nov, at 10:16:41AM, Dave Young wrote: > Matt, desc_version is already in boot_params.efi_info, so kexec-tools > can get the version from there. I do not need to export it as another > file. OK, cool. > I think for now we do not need worry much about the compatibility > issue, do you think I need add version checking in kexec-tools > currently? like below? > > if (desc_version != 1) /* current version is 1? */ > error out it is not supported Yes, something like that. If you already have kexec-specific ways of checking a version number then that's fine. Just make sure that, if the EFI memory descriptor structure is extended in the future and more files are exported for each descriptor, kexec-tools say "I don't know how to build a data structure for from these files". -- Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from arkanian.console-pimps.org ([212.110.184.194]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VikGQ-0005wf-Cy for kexec@lists.infradead.org; Tue, 19 Nov 2013 12:18:43 +0000 Date: Tue, 19 Nov 2013 12:18:14 +0000 From: Matt Fleming Subject: Re: [patch 5/7 v2] export efi runtime memory mapping to sysfs Message-ID: <20131119121814.GB11521@console-pimps.org> References: <20131105082007.872550445@dhcp-16-126.nay.redhat.com> <20131105082718.185728964@dhcp-16-126.nay.redhat.com> <20131113155027.GC17248@console-pimps.org> <20131114015047.GD4081@dhcp-16-126.nay.redhat.com> <20131118021641.GC4025@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131118021641.GC4025@dhcp-16-126.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Dave Young Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com, vgoyal@redhat.com On Mon, 18 Nov, at 10:16:41AM, Dave Young wrote: > Matt, desc_version is already in boot_params.efi_info, so kexec-tools > can get the version from there. I do not need to export it as another > file. OK, cool. > I think for now we do not need worry much about the compatibility > issue, do you think I need add version checking in kexec-tools > currently? like below? > > if (desc_version != 1) /* current version is 1? */ > error out it is not supported Yes, something like that. If you already have kexec-specific ways of checking a version number then that's fine. Just make sure that, if the EFI memory descriptor structure is extended in the future and more files are exported for each descriptor, kexec-tools say "I don't know how to build a data structure for from these files". -- Matt Fleming, Intel Open Source Technology Center _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec