From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: [BUG] ext2/3/4: dio reads stale data when we do some append dio writes
Date: Tue, 19 Nov 2013 20:18:43 +0800 [thread overview]
Message-ID: <20131119121843.GA5339@gmail.com> (raw)
In-Reply-To: <20131119120929.GO11434@dastard>
On Tue, Nov 19, 2013 at 11:09:29PM +1100, Dave Chinner wrote:
> On Tue, Nov 19, 2013 at 07:51:22PM +0800, Zheng Liu wrote:
> > On Tue, Nov 19, 2013 at 03:18:26AM -0800, Christoph Hellwig wrote:
> > > On Tue, Nov 19, 2013 at 07:19:47PM +0800, Zheng Liu wrote:
> > > > Yes, I know that XFS has a shared/exclusive lock. I guess that is why
> > > > it can pass the test. But another question is why xfs fails when we do
> > > > some append dio writes with doing buffered read.
> > >
> > > Can you provide a test case for that issue?
> >
> > Simple. Reader just need to open this file without O_DIRECT flag. I
> > paste the full code snippet below. Please take care of this line:
> > readfd = open(argv[1], /*O_DIRECT|*/O_RDONLY, S_IRWXU);
> >
> > The result of this program on my own sand box looks like below:
> > encounter an error: offset 0
> ....
> > if (ret >= 0) {
> > for (j = 0; j < ret; j++) {
> > if (rbuf[i] != 'a') {
> > fprintf(stderr, "encounter an error: offset %ld\n",
> > i);
> > goto err;
>
> Should be checking rbuf[j], perhaps?
Oops, it's my fault. Yes. it should check rbuf[j].
Thanks,
- Zheng
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-19 12:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 9:53 [BUG] ext2/3/4: dio reads stale data when we do some append dio writes Zheng Liu
2013-11-19 10:22 ` Christoph Hellwig
2013-11-19 10:45 ` Zheng Liu
2013-11-19 11:01 ` Christoph Hellwig
2013-11-19 11:19 ` Zheng Liu
2013-11-19 11:18 ` Christoph Hellwig
2013-11-19 11:51 ` Zheng Liu
2013-11-19 11:51 ` Zheng Liu
2013-11-19 12:09 ` Dave Chinner
2013-11-19 12:09 ` Dave Chinner
2013-11-19 12:18 ` Zheng Liu [this message]
2013-11-19 12:01 ` Dave Chinner
2013-11-19 12:20 ` Zheng Liu
2013-11-19 12:20 ` Zheng Liu
2013-11-19 10:54 ` Dmitry Monakhov
2013-11-19 11:45 ` Zheng Liu
2013-11-27 23:01 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119121843.GA5339@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.