From: "Pali Rohár" <pali.rohar@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input" <linux-input@vger.kernel.org>
Subject: Re: input question: ambient light sensor button
Date: Fri, 22 Nov 2013 12:13:49 +0100 [thread overview]
Message-ID: <201311221213.49580@pali> (raw)
In-Reply-To: <CAN+gG=HwuES-H4y5=_VcEQg4OiE2NYmra2+MzsbPusiOEq7Qsw@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 1857 bytes --]
On Wednesday 20 November 2013 16:59:42 Benjamin Tissoires wrote:
> Hi,
>
> On Wed, Nov 20, 2013 at 9:50 AM, Pali Rohár <pali.rohar@gmail.com> wrote:
> >> > > I guess we need patch adding
> >> > >
> >> > > #define KEY_ALS_TOGGLE 0x230
> >> > >
> >> > > Thanks.
> >> >
> >> > So there is no good key for als yet?
> >>
> >> No, but if you send me a patch adding it I will gladly
> >> apply it.
> >>
> >> Thanks.
> >
> > Ok, here is patch:
> >
> > Add key code for ambient light sensor button
> >
> > More notebooks have special button for enabling/disabling
> > ambient light sensor. This patch adding new als code to
> > input.h header file.
> >
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> >
> > diff --git a/include/uapi/linux/input.h
> > b/include/uapi/linux/input.h index a372627..1562f10 100644
> > --- a/include/uapi/linux/input.h
> > +++ b/include/uapi/linux/input.h
> > @@ -719,6 +719,8 @@ struct input_keymap_entry {
> >
> > #define BTN_DPAD_LEFT 0x222
> > #define BTN_DPAD_RIGHT 0x223
> >
> > +#define KEY_ALS_TOGGLE 0x230
>
> Could you just add a comment explaining that ALS is ambiant
> light sensor? Otherwise, I'm sure someone else will use this
> event code for an other thing... :)
>
> Cheers,
> Benjamin
Ok, here is new diff with comment:
diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
index a372627..7bacdb5 100644
--- a/include/uapi/linux/input.h
+++ b/include/uapi/linux/input.h
@@ -719,6 +719,8 @@ struct input_keymap_entry {
#define BTN_DPAD_LEFT 0x222
#define BTN_DPAD_RIGHT 0x223
+#define KEY_ALS_TOGGLE 0x230 /* Ambient light sensor */
+
#define BTN_TRIGGER_HAPPY 0x2c0
#define BTN_TRIGGER_HAPPY1 0x2c0
#define BTN_TRIGGER_HAPPY2 0x2c1
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-11-22 11:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-15 13:53 input question: ambient light sensor button Pali Rohár
2013-11-13 10:47 ` Jiri Kosina
2013-11-13 10:47 ` Jiri Kosina
2013-11-13 16:28 ` Dmitry Torokhov
2013-11-13 16:28 ` Dmitry Torokhov
2013-11-14 12:02 ` Pali Rohár
2013-11-19 21:27 ` Dmitry Torokhov
2013-11-20 14:50 ` Pali Rohár
2013-11-20 15:59 ` Benjamin Tissoires
2013-11-22 11:13 ` Pali Rohár [this message]
2013-11-26 19:19 ` Dmitry Torokhov
2013-11-26 19:19 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311221213.49580@pali \
--to=pali.rohar@gmail.com \
--cc=benjamin.tissoires@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.