Re: [PATCH] of: Add MIPI DSI bus device tree bindings

[Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

On Mon, Dec 02, 2013 at 08:57:20PM +0100, Tomasz Figa wrote:
> On Monday 02 of December 2013 16:37:11 Thierry Reding wrote:
[...]
> > +Example
> > +-------
> > +
> > +	dsi-host {
> > +		...
> > +
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		peripheral@0 {
> > +			compatible = "...";
> > +			reg = <0>;
> > +		};
> > +
> > +		...
> > +	};
> > 
> 
> In general, this looks good to me as a starter, so we could have support
> for DSI bus merged. IMHO we should consider adding some generic bus
> properties in future, though.

To be honest this looked somewhat minimal to me too at first, and then I
tried to come up with any other properties but couldn't think of any. Of
course anything that we add later on has the potential to break ABI
compatibility.

A few of the things I had in mind that might be added as properties were
the number of lanes or the video format. But those will already be
implied by the compatible value and therefore don't really belong in the
DT.

But if anyone can think of other properties that would be useful for DSI
host or peripherals, by all means, let me know.

> Anyway, have my
> 
> Reviewed-by: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Thanks,
Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]