From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751564Ab3LLNQm (ORCPT ); Thu, 12 Dec 2013 08:16:42 -0500 Received: from mga11.intel.com ([192.55.52.93]:3379 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387Ab3LLNQk (ORCPT ); Thu, 12 Dec 2013 08:16:40 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,878,1378882800"; d="scan'208";a="448931856" From: "Kirill A. Shutemov" To: Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cl@gentwo.org, kirill.shutemov@linux.intel.com, Andi Kleen , akpm@linux-foundation.org, Dave Hansen In-Reply-To: <20131211223632.8B2DFD41@viggo.jf.intel.com> References: <20131211223631.51094A3D@viggo.jf.intel.com> <20131211223632.8B2DFD41@viggo.jf.intel.com> Subject: RE: [PATCH 2/2] mm: blk-mq: uses page->list incorrectly Content-Transfer-Encoding: 7bit Message-Id: <20131212131636.B7C44E0090@blue.fi.intel.com> Date: Thu, 12 Dec 2013 15:16:36 +0200 (EET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dave Hansen wrote: > > From: Dave Hansen > > 'struct page' has two list_head fields: 'lru' and 'list'. > Conveniently, they are unioned together. This means that code > can use them interchangably, which gets horribly confusing. > > The blk-mq made the logical decision to try to use page->list. > But, that field was actually introduced just for the slub code. > ->lru is the right field to use outside of slab/slub. > > Signed-off-by: Dave Hansen Looks good to me. Acked-by: Kirill A. Shutemov for both. -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f45.google.com (mail-pb0-f45.google.com [209.85.160.45]) by kanga.kvack.org (Postfix) with ESMTP id E82DF6B0037 for ; Thu, 12 Dec 2013 08:16:44 -0500 (EST) Received: by mail-pb0-f45.google.com with SMTP id rp16so495338pbb.4 for ; Thu, 12 Dec 2013 05:16:44 -0800 (PST) Received: from mga11.intel.com (mga11.intel.com. [192.55.52.93]) by mx.google.com with ESMTP id g5si16512619pav.172.2013.12.12.05.16.40 for ; Thu, 12 Dec 2013 05:16:43 -0800 (PST) From: "Kirill A. Shutemov" In-Reply-To: <20131211223632.8B2DFD41@viggo.jf.intel.com> References: <20131211223631.51094A3D@viggo.jf.intel.com> <20131211223632.8B2DFD41@viggo.jf.intel.com> Subject: RE: [PATCH 2/2] mm: blk-mq: uses page->list incorrectly Content-Transfer-Encoding: 7bit Message-Id: <20131212131636.B7C44E0090@blue.fi.intel.com> Date: Thu, 12 Dec 2013 15:16:36 +0200 (EET) Sender: owner-linux-mm@kvack.org List-ID: To: Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cl@gentwo.org, kirill.shutemov@linux.intel.com, Andi Kleen , akpm@linux-foundation.org Dave Hansen wrote: > > From: Dave Hansen > > 'struct page' has two list_head fields: 'lru' and 'list'. > Conveniently, they are unioned together. This means that code > can use them interchangably, which gets horribly confusing. > > The blk-mq made the logical decision to try to use page->list. > But, that field was actually introduced just for the slub code. > ->lru is the right field to use outside of slab/slub. > > Signed-off-by: Dave Hansen Looks good to me. Acked-by: Kirill A. Shutemov for both. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org