From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 6/6] drm/i915: inform drm_fb_helper if we abandoned a connected output Date: Thu, 12 Dec 2013 14:34:18 -0800 Message-ID: <20131212143418.76602e8a@jbarnes-desktop> References: <1386880917-2951-1-git-send-email-jbarnes@virtuousgeek.org> <1386880917-2951-6-git-send-email-jbarnes@virtuousgeek.org> <20131212223041.GC1403@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from alt-proxy11.mail.unifiedlayer.com (alt-proxy11.mail.unifiedlayer.com [74.220.211.241]) by gabe.freedesktop.org (Postfix) with SMTP id AAFBBFA85F for ; Thu, 12 Dec 2013 14:32:34 -0800 (PST) In-Reply-To: <20131212223041.GC1403@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 12 Dec 2013 22:30:41 +0000 Chris Wilson wrote: > On Thu, Dec 12, 2013 at 12:41:57PM -0800, Jesse Barnes wrote: > > Otherwise subsequent fb activity will try to do blank/unblank on outputs > > that were never fully enabled. > > Hmm, actually this highlights a bug in drm_setup_crtcs() that we do not > reconstruct enabled[] after a return false here. > > Only the first enabled[i] = false is required where we continue rather > than abort. Yeah this one took me awhile to find. Not surprised if there are other bugs lurking here. This one fixes the issue introduced by these patches at least in the multihead config. -- Jesse Barnes, Intel Open Source Technology Center