From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vr8s2-0006Wv-Bi for mharc-grub-devel@gnu.org; Thu, 12 Dec 2013 11:12:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr8rw-0006Wb-5y for grub-devel@gnu.org; Thu, 12 Dec 2013 11:12:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vr8rq-00008y-VP for grub-devel@gnu.org; Thu, 12 Dec 2013 11:12:08 -0500 Received: from v6.chiark.greenend.org.uk ([2001:ba8:1e3::]:48306 helo=chiark.greenend.org.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr8rq-00008L-Ib for grub-devel@gnu.org; Thu, 12 Dec 2013 11:12:02 -0500 Received: from [172.20.153.9] (helo=riva.pelham.vpn.ucam.org) by chiark.greenend.org.uk (Debian Exim 4.72 #1) with esmtps (return-path cjwatson@ubuntu.com) id 1Vr8rp-0005MI-IT for grub-devel@gnu.org; Thu, 12 Dec 2013 16:12:01 +0000 Received: from ns1.pelham.vpn.ucam.org ([172.20.153.2] helo=riva.ucam.org) by riva.pelham.vpn.ucam.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Vr8ro-0002bp-IQ for grub-devel@gnu.org; Thu, 12 Dec 2013 16:12:00 +0000 Date: Thu, 12 Dec 2013 16:11:59 +0000 From: Colin Watson To: grub-devel@gnu.org Subject: Re: [PATCH 2/4] Accept environment variables on the command line for Xen. Message-ID: <20131212161159.GF1431@riva.ucam.org> References: <20131212153643.GA1431@riva.ucam.org> <20131212153722.GC1431@riva.ucam.org> <20131212194805.5d81a2e7@opensuse.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131212194805.5d81a2e7@opensuse.site> User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:ba8:1e3:: X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Dec 2013 16:12:12 -0000 On Thu, Dec 12, 2013 at 07:48:05PM +0400, Andrey Borzenkov wrote: > > + Accept environment variables on the command line for Xen. > > Thank you! > > It may make sense to generalize it to other archs. At least EFI > definitely comes in mind. In this case platform specific part is only > to fetch parameter string(s). What about > > - move fetch_command_line_word and parse_command_line to separate file > that is included for specific platforms only > - make each platform that can accept fetch parameters in platform > specific way and call common code (parse_command_line) > > Does it make sense? That might well be sensible, yes (multiboot too IIRC), but I was concerned about generalising this too early since some ports already have specialised requirements for command-line parsing - e.g. I think mipsel-loongson has some oddities. Maybe it would be best to do that kind of thing as a follow-up patch series? -- Colin Watson [cjwatson@ubuntu.com]