From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 6/6] drm/i915: inform drm_fb_helper if we
 abandoned a connected output
Date: Thu, 12 Dec 2013 22:30:41 +0000
Message-ID: <20131212223041.GC1403@nuc-i3427.alporthouse.com>
References: <1386880917-2951-1-git-send-email-jbarnes@virtuousgeek.org>
	<1386880917-2951-6-git-send-email-jbarnes@virtuousgeek.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118])
	by gabe.freedesktop.org (Postfix) with ESMTP id 01662FA7E3
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 12 Dec 2013 14:30:45 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1386880917-2951-6-git-send-email-jbarnes@virtuousgeek.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Dec 12, 2013 at 12:41:57PM -0800, Jesse Barnes wrote:
> Otherwise subsequent fb activity will try to do blank/unblank on outputs
> that were never fully enabled.

Hmm, actually this highlights a bug in drm_setup_crtcs() that we do not
reconstruct enabled[] after a return false here.

Only the first enabled[i] = false is required where we continue rather
than abort.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre