From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH net-next v2 9/9] xen-netback: Aggregate TX unmap operations Date: Fri, 13 Dec 2013 15:44:35 +0000 Message-ID: <20131213154435.GP21900__43882.762178737$1386949572$gmane$org@zion.uk.xensource.com> References: <1386892097-15502-1-git-send-email-zoltan.kiss@citrix.com> <1386892097-15502-10-git-send-email-zoltan.kiss@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VrUut-0005bo-9f for xen-devel@lists.xenproject.org; Fri, 13 Dec 2013 15:44:39 +0000 Content-Disposition: inline In-Reply-To: <1386892097-15502-10-git-send-email-zoltan.kiss@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Zoltan Kiss Cc: jonathan.davies@citrix.com, wei.liu2@citrix.com, ian.campbell@citrix.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Thu, Dec 12, 2013 at 11:48:17PM +0000, Zoltan Kiss wrote: > Unmapping causes TLB flushing, therefore we should make it in the largest > possible batches. However we shouldn't starve the guest for too long. So if > the guest has space for at least two big packets and we don't have at least a > quarter ring to unmap, delay it for at most 1 milisec. > Is this solution temporary or permanent? If it is permanent would it make sense to make these parameter tunable? Wei.